New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event audience field to event type #891

Merged
merged 8 commits into from Jun 21, 2018

Conversation

4 participants
@rcillo
Member

rcillo commented Jun 18, 2018

https://techjira.zalando.net/browse/ARUHA-1508

Extend the API with Zalando's internal details.

- external_partner
- external_public
description: |
Zalando's internal detail. Intended target audience of the API. Relevant for standards around quality of

This comment has been minimized.

@lmontrieux

lmontrieux Jun 18, 2018

Member

I think that 'Zalando internal' should not end up in an open source project. Isn't it the case that it could be useful to someone else?

This comment has been minimized.

@rcillo

rcillo Jun 18, 2018

Member

I agree with you. I can delete this sentence and pretend it's useful to someone.

This comment has been minimized.

@rcillo
@codecov-io

This comment has been minimized.

codecov-io commented Jun 18, 2018

Codecov Report

Merging #891 into master will increase coverage by 0.05%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     54.02%   54.08%   +0.05%     
- Complexity     1748     1754       +6     
============================================
  Files           315      316       +1     
  Lines          9653     9663      +10     
  Branches        886      886              
============================================
+ Hits           5215     5226      +11     
+ Misses         4115     4114       -1     
  Partials        323      323
Impacted Files Coverage Δ Complexity Δ
.../java/org/zalando/nakadi/domain/EventTypeBase.java 98.66% <100%> (+0.07%) 30 <2> (+2) ⬆️
.../main/java/org/zalando/nakadi/domain/Audience.java 100% <100%> (ø) 1 <1> (?)
...a/org/zalando/nakadi/service/EventTypeService.java 76.89% <75%> (-0.04%) 47 <2> (+2)
...n/java/org/zalando/nakadi/service/EventStream.java 75% <0%> (+1.61%) 30% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faccad8...75bdeea. Read the comment docs.

@v-stepanov

This comment has been minimized.

Member

v-stepanov commented Jun 19, 2018

👍

1 similar comment
@rcillo

This comment has been minimized.

Member

rcillo commented Jun 19, 2018

👍

@rcillo

This comment has been minimized.

Member

rcillo commented Jun 19, 2018

deploy validation please

@v-stepanov

This comment has been minimized.

Member

v-stepanov commented Jun 21, 2018

👍

1 similar comment
@rcillo

This comment has been minimized.

Member

rcillo commented Jun 21, 2018

👍

@rcillo rcillo merged commit 4a7cbed into master Jun 21, 2018

6 of 7 checks passed

zappr Approval validation in progress.
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 90% of diff hit (target 54.02%)
Details
codecov/project 54.08% (+0.05%) compared to faccad8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr/pr/specification PR has passed specification checks

@rcillo rcillo deleted the aruha-1723-new-metadata-fields branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment