New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hila feature flag #893

Merged
merged 7 commits into from Jun 26, 2018

Conversation

4 participants
@lmontrieux
Member

lmontrieux commented Jun 18, 2018

Remove HILA feature flag

Description

This PR removes the HILA feature flag. Since the low-level API is deprecated, it does not make much sense anymore to keep this flag. Removing it makes the code slightly easier to understand.

Review

  • Tests
  • Documentation
  • CHANGELOG
@codecov-io

This comment has been minimized.

codecov-io commented Jun 18, 2018

Codecov Report

Merging #893 into master will decrease coverage by 0.04%.
The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #893      +/-   ##
============================================
- Coverage     54.07%   54.02%   -0.05%     
+ Complexity     1759     1755       -4     
============================================
  Files           316      316              
  Lines          9680     9668      -12     
  Branches        887      884       -3     
============================================
- Hits           5234     5223      -11     
  Misses         4122     4122              
+ Partials        324      323       -1
Impacted Files Coverage Δ Complexity Δ
...g/zalando/nakadi/service/FeatureToggleService.java 51.61% <ø> (-1.52%) 0 <0> (ø)
.../nakadi/controller/PostSubscriptionController.java 83.33% <ø> (-0.54%) 9 <0> (ø)
...ando/nakadi/controller/SubscriptionController.java 44.44% <ø> (-7.17%) 8 <0> (-2)
...akadi/controller/SubscriptionStreamController.java 13.33% <ø> (+0.43%) 2 <0> (ø) ⬇️
...g/zalando/nakadi/controller/CursorsController.java 59.67% <90.9%> (-3.4%) 9 <2> (-2)
...ceptions/runtime/FeatureNotAvailableException.java 0% <0%> (-75%) 0% <0%> (-1%)
...n/java/org/zalando/nakadi/service/EventStream.java 75% <0%> (+1.61%) 30% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3aa74...90998b2. Read the comment docs.

@rcillo

This comment has been minimized.

Member

rcillo commented Jun 19, 2018

CI failed because it seems the application did not launch. I'll retry but maybe you want to check it out as well.

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Jun 19, 2018

@rcillo it runs on my laptop, so it seems a bit strange. I'll have a look

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Jun 19, 2018

@rcillo fixed it :)

@rcillo

This comment has been minimized.

Member

rcillo commented Jun 20, 2018

👍

1 similar comment
@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Jun 20, 2018

👍

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Jun 20, 2018

deploy validation please

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Jun 25, 2018

👍

1 similar comment
@rcillo

This comment has been minimized.

Member

rcillo commented Jun 25, 2018

👍

@lmontrieux

This comment has been minimized.

Member

lmontrieux commented Jun 26, 2018

👍

1 similar comment
@antban

This comment has been minimized.

Member

antban commented Jun 26, 2018

👍

@lmontrieux lmontrieux merged commit 1643b21 into zalando:master Jun 26, 2018

5 of 6 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
codecov/patch 90.9% of diff hit (target 54.07%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +36.83% compared to ea3aa74
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr Approvals: @lmontrieux, @antban.
zappr/pr/specification PR has passed specification checks

@lmontrieux lmontrieux deleted the lmontrieux:remove-hila-feature-flag branch Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment