Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARUHA-1750 Fix last cursor for nakadi stats endpoint #897

Merged
merged 1 commit into from Jun 26, 2018
Merged

Conversation

@antban
Copy link
Member

@antban antban commented Jun 26, 2018

ARUHA-1750

@antban antban force-pushed the ARUHA-1750 branch from 001655d to f4ed256 Jun 26, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 26, 2018

Codecov Report

Merging #897 into master will decrease coverage by 0.03%.
The diff coverage is 27.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #897      +/-   ##
============================================
- Coverage     54.07%   54.03%   -0.04%     
- Complexity     1759     1761       +2     
============================================
  Files           316      316              
  Lines          9680     9692      +12     
  Branches        887      890       +3     
============================================
+ Hits           5234     5237       +3     
- Misses         4122     4131       +9     
  Partials        324      324
Impacted Files Coverage Δ Complexity Δ
...alando/nakadi/controller/PartitionsController.java 69.66% <27.77%> (-9.56%) 13 <1> (+1)
...n/java/org/zalando/nakadi/service/EventStream.java 75% <0%> (+1.61%) 30% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3aa74...f4ed256. Read the comment docs.

@antban
Copy link
Member Author

@antban antban commented Jun 26, 2018

👍

@antban
Copy link
Member Author

@antban antban commented Jun 26, 2018

deploy validation please

@lmontrieux
Copy link
Member

@lmontrieux lmontrieux commented Jun 26, 2018

👍

@antban antban merged commit 24ff0c1 into master Jun 26, 2018
6 of 8 checks passed
6 of 8 checks passed
codecov/patch 27.77% of diff hit (target 54.07%)
Details
codecov/project 54.03% (-0.04%) compared to ea3aa74
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
aruha/jenkins Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @antban, @lmontrieux.
zappr/pr/specification PR has passed specification checks
@antban antban deleted the ARUHA-1750 branch Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.