New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Log compaction feature toggle #913

Merged
merged 2 commits into from Jul 18, 2018

Conversation

3 participants
@rcillo
Member

rcillo commented Jul 18, 2018

In order to unblock releases, we are disabling this feature, since it's
not production ready yet.

Deployment Notes

In order to enable the feature, please change the value of the toggle.

rcillo added some commits Jul 18, 2018

Add Log compaction feature toggle
In order to unblock releases, we are disabling this feature, since it's
not production ready yet.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 18, 2018

Codecov Report

Merging #913 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #913      +/-   ##
============================================
+ Coverage     53.58%   53.63%   +0.04%     
- Complexity     1774     1777       +3     
============================================
  Files           323      323              
  Lines          9850     9854       +4     
  Branches        900      902       +2     
============================================
+ Hits           5278     5285       +7     
+ Misses         4237     4234       -3     
  Partials        335      335
Impacted Files Coverage Δ Complexity Δ
.../nakadi/controller/PostSubscriptionController.java 89.28% <ø> (+5.95%) 9 <0> (ø) ⬇️
...g/zalando/nakadi/controller/ExceptionHandling.java 52.27% <0%> (-2.49%) 13 <0> (ø)
...g/zalando/nakadi/service/FeatureToggleService.java 53.12% <100%> (+1.51%) 0 <0> (ø) ⬇️
...a/org/zalando/nakadi/service/EventTypeService.java 76.19% <100%> (+0.26%) 61 <0> (+2) ⬆️
...ceptions/runtime/FeatureNotAvailableException.java 75% <0%> (+75%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e5de7...1fa3208. Read the comment docs.

codecov-io commented Jul 18, 2018

Codecov Report

Merging #913 into master will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #913      +/-   ##
============================================
+ Coverage     53.58%   53.63%   +0.04%     
- Complexity     1774     1777       +3     
============================================
  Files           323      323              
  Lines          9850     9854       +4     
  Branches        900      902       +2     
============================================
+ Hits           5278     5285       +7     
+ Misses         4237     4234       -3     
  Partials        335      335
Impacted Files Coverage Δ Complexity Δ
.../nakadi/controller/PostSubscriptionController.java 89.28% <ø> (+5.95%) 9 <0> (ø) ⬇️
...g/zalando/nakadi/controller/ExceptionHandling.java 52.27% <0%> (-2.49%) 13 <0> (ø)
...g/zalando/nakadi/service/FeatureToggleService.java 53.12% <100%> (+1.51%) 0 <0> (ø) ⬇️
...a/org/zalando/nakadi/service/EventTypeService.java 76.19% <100%> (+0.26%) 61 <0> (+2) ⬆️
...ceptions/runtime/FeatureNotAvailableException.java 75% <0%> (+75%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e5de7...1fa3208. Read the comment docs.

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 18, 2018

Member

👍

Member

lmontrieux commented Jul 18, 2018

👍

@rcillo

This comment has been minimized.

Show comment
Hide comment
@rcillo

rcillo Jul 18, 2018

Member

👍

Member

rcillo commented Jul 18, 2018

👍

@rcillo rcillo merged commit 24c4631 into master Jul 18, 2018

7 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 71.42% of diff hit (target 53.58%)
Details
codecov/project 53.63% (+0.04%) compared to f7e5de7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @lmontrieux, @rcillo.
zappr/pr/specification PR has passed specification checks

@rcillo rcillo deleted the log-compaction-feature-flag branch Jul 18, 2018

@rcillo rcillo restored the log-compaction-feature-flag branch Jul 18, 2018

@rcillo rcillo deleted the log-compaction-feature-flag branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment