New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy feature toggles #914

Merged
merged 9 commits into from Jul 31, 2018

Conversation

6 participants
@ferbncode
Member

ferbncode commented Jul 20, 2018

Remove legacy feature toggles to control the tech debit in order to not slowdown the development process.

Zalando ticket : ARUHA-1736

Description

The following feature toggles have been removed:

  • CHECK_PARTITIONS_KEYS
  • CHECK_OWNING_APPLICATION
  • LIMIT_CONSUMERS_NUMBER
  • SEND_BATCH_VIA_OUTPUT_STREAM
Remove legacy feature toggles
Remove legacy feature toggles to control the tech debit in order to not slowdown the development process.
@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 20, 2018

Member

@ferbncode one unit test is failing, could you please have a look?

Member

lmontrieux commented Jul 20, 2018

@ferbncode one unit test is failing, could you please have a look?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 22, 2018

Codecov Report

Merging #914 into master will increase coverage by 0.67%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #914      +/-   ##
===========================================
+ Coverage     53.63%   54.3%   +0.67%     
+ Complexity     1777    1770       -7     
===========================================
  Files           323     319       -4     
  Lines          9854    9678     -176     
  Branches        902     886      -16     
===========================================
- Hits           5285    5256      -29     
+ Misses         4234    4091     -143     
+ Partials        335     331       -4
Impacted Files Coverage Δ Complexity Δ
...alando/nakadi/service/EventStreamWriterBinary.java 94.66% <ø> (ø) 8 <0> (ø) ⬇️
...zalando/nakadi/controller/EventTypeController.java 90.74% <ø> (+4.77%) 22 <0> (ø) ⬇️
...g/zalando/nakadi/service/FeatureToggleService.java 46.42% <ø> (-6.7%) 0 <0> (ø)
...lando/nakadi/controller/EventStreamController.java 85.71% <ø> (+3.04%) 21 <0> (ø) ⬇️
.../nakadi/controller/PostSubscriptionController.java 92% <ø> (+2.71%) 8 <0> (-1) ⬇️
...org/zalando/nakadi/service/EventStreamFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/zalando/nakadi/service/EventStream.java 75% <100%> (+1.61%) 30 <1> (+1) ⬆️
...a/org/zalando/nakadi/service/EventTypeService.java 76.1% <100%> (-0.09%) 60 <0> (-1)
...vice/subscription/SubscriptionStreamerFactory.java 37.77% <50%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c4631...dfcfa48. Read the comment docs.

codecov-io commented Jul 22, 2018

Codecov Report

Merging #914 into master will increase coverage by 0.67%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #914      +/-   ##
===========================================
+ Coverage     53.63%   54.3%   +0.67%     
+ Complexity     1777    1770       -7     
===========================================
  Files           323     319       -4     
  Lines          9854    9678     -176     
  Branches        902     886      -16     
===========================================
- Hits           5285    5256      -29     
+ Misses         4234    4091     -143     
+ Partials        335     331       -4
Impacted Files Coverage Δ Complexity Δ
...alando/nakadi/service/EventStreamWriterBinary.java 94.66% <ø> (ø) 8 <0> (ø) ⬇️
...zalando/nakadi/controller/EventTypeController.java 90.74% <ø> (+4.77%) 22 <0> (ø) ⬇️
...g/zalando/nakadi/service/FeatureToggleService.java 46.42% <ø> (-6.7%) 0 <0> (ø)
...lando/nakadi/controller/EventStreamController.java 85.71% <ø> (+3.04%) 21 <0> (ø) ⬇️
.../nakadi/controller/PostSubscriptionController.java 92% <ø> (+2.71%) 8 <0> (-1) ⬇️
...org/zalando/nakadi/service/EventStreamFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/java/org/zalando/nakadi/service/EventStream.java 75% <100%> (+1.61%) 30 <1> (+1) ⬆️
...a/org/zalando/nakadi/service/EventTypeService.java 76.1% <100%> (-0.09%) 60 <0> (-1)
...vice/subscription/SubscriptionStreamerFactory.java 37.77% <50%> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c4631...dfcfa48. Read the comment docs.

@adyach

This comment has been minimized.

Show comment
Hide comment
@adyach

adyach Jul 23, 2018

Member

LGTM, I suggest to open another PR to remove the code, which we do not use anymore, e.g.: EventStreamWriterString, ConsumerLimitingService.

Member

adyach commented Jul 23, 2018

LGTM, I suggest to open another PR to remove the code, which we do not use anymore, e.g.: EventStreamWriterString, ConsumerLimitingService.

@rcillo

This comment has been minimized.

Show comment
Hide comment
@rcillo

rcillo Jul 23, 2018

Member

👍

Member

rcillo commented Jul 23, 2018

👍

@rcillo

This comment has been minimized.

Show comment
Hide comment
@rcillo

rcillo Jul 23, 2018

Member

@ferbncode congrats on your first contribution to Nakadi 😄 👏

Member

rcillo commented Jul 23, 2018

@ferbncode congrats on your first contribution to Nakadi 😄 👏

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

👎

Member

lmontrieux commented Jul 23, 2018

👎

Show outdated Hide outdated CHANGELOG.md
@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

@ferbncode good work, and congrats on your first contribution. But there is one last small thing to change. I wrote a comment a moment ago.

Member

lmontrieux commented Jul 23, 2018

@ferbncode good work, and congrats on your first contribution. But there is one last small thing to change. I wrote a comment a moment ago.

@rcillo

This comment has been minimized.

Show comment
Hide comment
@rcillo

rcillo Jul 23, 2018

Member

👍

Member

rcillo commented Jul 23, 2018

👍

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

👍

Member

lmontrieux commented Jul 23, 2018

👍

@ferbncode

This comment has been minimized.

Show comment
Hide comment
@ferbncode

ferbncode Jul 23, 2018

Member

deploy validation please

Member

ferbncode commented Jul 23, 2018

deploy validation please

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 26, 2018

Member

👍

Member

lmontrieux commented Jul 26, 2018

👍

@ferbncode

This comment has been minimized.

Show comment
Hide comment
@ferbncode

ferbncode Jul 26, 2018

Member

👍

Member

ferbncode commented Jul 26, 2018

👍

@ferbncode ferbncode closed this Jul 27, 2018

@ferbncode ferbncode reopened this Jul 27, 2018

@ferbncode ferbncode closed this Jul 30, 2018

@ferbncode ferbncode reopened this Jul 30, 2018

@ferbncode ferbncode merged commit 9a92d5b into zalando:master Jul 31, 2018

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 66.66% of diff hit (target 53.63%)
Details
codecov/project 54.3% (+0.67%) compared to 24c4631
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr Approvals: @lmontrieux, @ferbncode.
zappr/pr/specification PR has passed specification checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment