New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARUHA-1798 Upgrade kafka client to 1.1.1 #915

Merged
merged 2 commits into from Jul 23, 2018

Conversation

3 participants
@lmontrieux
Member

lmontrieux commented Jul 23, 2018

Upgrade Kafka client to 1.1.1

Zalando ticket : ARUHA-1798

Description

New version of Kafka client

Review

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

This version of Kafka client should be compatible with all versions of Kafka clusters from 0.10.1.0 up.

lmontrieux added some commits Jul 23, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 23, 2018

Codecov Report

Merging #915 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #915      +/-   ##
============================================
+ Coverage     53.63%   53.67%   +0.04%     
- Complexity     1777     1779       +2     
============================================
  Files           323      323              
  Lines          9854     9854              
  Branches        902      902              
============================================
+ Hits           5285     5289       +4     
+ Misses         4234     4232       -2     
+ Partials        335      333       -2
Impacted Files Coverage Δ Complexity Δ
...n/java/org/zalando/nakadi/service/EventStream.java 75% <0%> (+1.61%) 30% <0%> (+1%) ⬆️
...va/org/zalando/nakadi/service/EventsProcessor.java 86.53% <0%> (+3.84%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c4631...56c8d5a. Read the comment docs.

codecov-io commented Jul 23, 2018

Codecov Report

Merging #915 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #915      +/-   ##
============================================
+ Coverage     53.63%   53.67%   +0.04%     
- Complexity     1777     1779       +2     
============================================
  Files           323      323              
  Lines          9854     9854              
  Branches        902      902              
============================================
+ Hits           5285     5289       +4     
+ Misses         4234     4232       -2     
+ Partials        335      333       -2
Impacted Files Coverage Δ Complexity Δ
...n/java/org/zalando/nakadi/service/EventStream.java 75% <0%> (+1.61%) 30% <0%> (+1%) ⬆️
...va/org/zalando/nakadi/service/EventsProcessor.java 86.53% <0%> (+3.84%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c4631...56c8d5a. Read the comment docs.

@adyach

This comment has been minimized.

Show comment
Hide comment
@adyach

adyach Jul 23, 2018

Member

👍

Member

adyach commented Jul 23, 2018

👍

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

👍

Member

lmontrieux commented Jul 23, 2018

👍

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

deploy validation please

Member

lmontrieux commented Jul 23, 2018

deploy validation please

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

deploy validation please

Member

lmontrieux commented Jul 23, 2018

deploy validation please

@lmontrieux

This comment has been minimized.

Show comment
Hide comment
@lmontrieux

lmontrieux Jul 23, 2018

Member

deploy validation please

Member

lmontrieux commented Jul 23, 2018

deploy validation please

@lmontrieux lmontrieux merged commit 7a9a6ef into master Jul 23, 2018

5 of 8 checks passed

codecov/patch CI failed.
Details
codecov/project CI failed.
Details
aruha/jenkins Build finished.
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
zappr Approvals: @adyach, @lmontrieux.
zappr/pr/specification PR has passed specification checks

@lmontrieux lmontrieux deleted the upgrade-kafka-1-1-1 branch Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment