From 2eec0e5b52ba4f3d73e1e481d44a8b7fbab01cad Mon Sep 17 00:00:00 2001
From: Oleksii Kliukin <oleksii.kliukin@zalando.de>
Date: Fri, 15 Sep 2017 13:48:08 +0200
Subject: [PATCH] Address code review.

---
 pkg/cluster/util.go | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/pkg/cluster/util.go b/pkg/cluster/util.go
index f3bc9a8a4..2a1442886 100644
--- a/pkg/cluster/util.go
+++ b/pkg/cluster/util.go
@@ -34,36 +34,33 @@ func isValidFlag(flag string) bool {
 func invertFlag(flag string) string {
 	if flag[:2] == "NO" {
 		return flag[2:]
-	} else {
-		return "NO" + flag
 	}
+	return "NO" + flag
 }
 
-func normalizeUserFlags(userFlags []string) (flags []string, err error) {
+func normalizeUserFlags(userFlags []string) ([]string, error) {
 	uniqueFlags := make(map[string]bool)
 	addLogin := true
 
 	for _, flag := range userFlags {
 		if !alphaNumericRegexp.MatchString(flag) {
-			err = fmt.Errorf("user flag %q is not alphanumeric", flag)
-			return
+			return nil, fmt.Errorf("user flag %q is not alphanumeric", flag)
 		}
+
 		flag = strings.ToUpper(flag)
 		if _, ok := uniqueFlags[flag]; !ok {
 			if !isValidFlag(flag) {
-				err = fmt.Errorf("user flag %q is not valid", flag)
-				return
+				return nil, fmt.Errorf("user flag %q is not valid", flag)
 			}
 			invFlag := invertFlag(flag)
 			if uniqueFlags[invFlag] {
-				err = fmt.Errorf("conflicting user flags: %q and %q", flag, invFlag)
-				return
+				return nil, fmt.Errorf("conflicting user flags: %q and %q", flag, invFlag)
 			}
 			uniqueFlags[flag] = true
 		}
 	}
 
-	flags = []string{}
+	flags := []string{}
 	for k := range uniqueFlags {
 		if k == constants.RoleFlagNoLogin || k == constants.RoleFlagLogin {
 			addLogin = false
@@ -79,7 +76,7 @@ func normalizeUserFlags(userFlags []string) (flags []string, err error) {
 		flags = append(flags, constants.RoleFlagLogin)
 	}
 
-	return
+	return flags, nil
 }
 
 func specPatch(spec interface{}) ([]byte, error) {