Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.24.0 Requires Spring 5 #304

Closed
jbspeakr opened this issue Jun 4, 2019 · 4 comments · Fixed by #305
Closed

Release 0.24.0 Requires Spring 5 #304

jbspeakr opened this issue Jun 4, 2019 · 4 comments · Fixed by #305

Comments

@jbspeakr
Copy link
Member

jbspeakr commented Jun 4, 2019

Description

Although introduced in a minor version change, the "Added support for ResponseStatusException" results in a major incompatibility issue as problem-spring-web now requires Spring 5.0 or greater because ResponseStatusException was just introduced with Spring 5.0.

Expected Behavior

There are no major incompatibilities introduced in a non-major version change. Updating a library to a newer minor version should not require to upgrade major versions of underlying frameworks.

Actual Behavior

Updating problem-spring-web from 0.23.0 to 0.24.0 results in java.lang.ClassNotFoundException: org.springframework.web.server.ResponseStatusException.

Possible Fix

  • Support Spring5 conditionally without breaking compatibility to Spring4 or
  • Introduce hard Spring5 requirement in a new major version

Steps to Reproduce

  1. Take a SpringBoot 1.5.x application
  2. Introduce problem-spring-web 0.24.0
  3. Startup Context

Context

Our plan was to simply update to latest 0.x minor version to see whether it fixes another problem we ran into when using problem-spring-web together with springboot.

@jbspeakr
Copy link
Member Author

jbspeakr commented Jun 4, 2019

PS: I know the new requirement towards Spring5 (and hence SpringBoot2) is documented in the readme. However, the current versioning does not reflect that. Also it's not transparent that Spring4 is not supported anymore.

@jbspeakr
Copy link
Member Author

jbspeakr commented Jun 4, 2019

PPS: I know Spring 1.5.x is EOL in August and that we should upgrade. Reflecting major incompatibilities in versions is a good idea anyway ;D

@whiskeysierra
Copy link
Collaborator

There are no major incompatibilities introduced in a non-major version change. Updating a library to a newer minor version should not require to upgrade major versions of underlying frameworks.

Technically...

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

https://semver.org/#spec-item-4

I'll update the readme to give a strong hint about compatibility.

whiskeysierra added a commit that referenced this issue Jun 4, 2019
@lukasniemeier-zalando
Copy link
Member

Maybe it's time for a 1.0.0 release 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants