Forward headers from webhook filter responses#1261
Merged
aryszka merged 4 commits intozalando:masterfrom Jan 7, 2020
Merged
Conversation
Signed-off-by: Daniel Middlecote <dlmiddlecote@gmail.com>
filter Signed-off-by: Daniel Middlecote <dlmiddlecote@gmail.com>
response Signed-off-by: Daniel Middlecote <dlmiddlecote@gmail.com>
dlmiddlecote
force-pushed
the
feature/webhook-auth-forward-headers
branch
from
e9ff5e9 to
ff37704
Compare
Contributor
Author
|
Not sure why the tests failed, can't reproduce locally. |
Member
|
From the docs and or message, I see that it’s a breaking change. Travis errors are most likely not your problem and needs a retrigger in Travis. |
Contributor
Author
|
Hey @szuecs, this shouldn't be a breaking change, as the second argument to the webhook filter doesn't need to be specified, and if it's not, the filter will work as it does today. I guess the documentation doesn't convey that well enough. |
Member
|
Can you please have both as examples, such that it’s clear in the docs? |
…tional Signed-off-by: Daniel Middlecote <dlmiddlecote@gmail.com>
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
webhookfilter so that it can take a second argument, a comma-separated list of header names, that should be copied from the webhook response to the continuing request, if the webhook response is authorized.i.e.
webhook("auth-endpoint", "Headers-To-Copy,And-More")