enhance tracing #887
Merged
enhance tracing #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature: add hostname tag to ingress span to show the instance of the trace feature: trace log retries Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
szuecs
force-pushed
the
feature/enhance-tracing
branch
from
fde3d4f
to
ef6ca53
Compare
ruiaraujo
reviewed
Dec 20, 2018
| if span := ot.SpanFromContext(ctx.Request().Context()); span != nil { | ||
| span.LogKV(`circuit_breaker`, `open`) | ||
| } | ||
| tracing.LogKV("circuit_breaker", "open", ctx.request.Context()) |
There was a problem hiding this comment.
Here can add a error tag true which shows in the ui.
There was a problem hiding this comment.
We should also do that in case of any proxy errors.
There was a problem hiding this comment.
I added it to the ingress span in case proxy.do() returns an error, because the client does not care which part errors and the proxy span already sets this tag on error in proxy.makeBackendRequest
…l error returns from proxy.do() Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
|
👍 |
1 similar comment
|
👍 |
|
This PR partially solved #797, because it now logs start and stop in the trace and has one span open for all request filter processing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #860
feature: trace filters and log filter names start/stop
feature: add hostname tag to ingress span to show the instance of the trace
feature: trace log retries
Signed-off-by: Sandor Szücs sandor.szuecs@zalando.de