Fix metadata service for OpenStack #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests.get().json() returns a dict and not an object. fixes #525
|
The tests failed, but looking at the error |
Jan-M
reviewed
Jan 7, 2021
| @@ -389,7 +389,7 @@ def get_instance_metadata(provider): | |||
| mapping = {} # Disable multi-url fetch | |||
| url = 'http://169.254.169.254/openstack/latest/meta_data.json' | |||
| openstack_metadata = requests.get(url, timeout=5).json() | |||
| metadata['zone'] = openstack_metadata.availability_zone | |||
There was a problem hiding this comment.
there is no dealing at this point with errors?
There was a problem hiding this comment.
Yes, the old implementation just crashed. If the current MR has an issue the same would happen.
|
👍 |
1 similar comment
|
👍 |
|
Merged. |
dratzke
pushed a commit
to Patagona/spilo
that referenced
this pull request
May 25, 2021
dratzke
pushed a commit
to Patagona/spilo
that referenced
this pull request
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests.get().json() returns a dict and not an object.
fixes #525
@baylisscg you contributed the change a few months ago in https://github.com/zalando/spilo/pull/486/files. Maybe you could have a look at this change and the issue #525 and provide some feedback if you agree with it or if you see an issue?