New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect extraHosts of the hub container to node containers #186

Merged
merged 4 commits into from Jul 25, 2017

Conversation

3 participants
@toshiya
Contributor

toshiya commented Jul 17, 2017

Add feature to reflect the extraHost setting of the hub container to node containers. (Discussed in the issue #182)

  • code changes are only for DockerContainerClient.java, not consider the case of using kubernetes
  • logic to read extraHosts from the hub is based on the existing getZaleniumNetwork
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jul 17, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (issue-182@6ad8d07). Click here to learn what that means.
The diff coverage is 75%.

@@             Coverage Diff             @@
##             issue-182    #186   +/-   ##
===========================================
  Coverage             ?   69.3%           
  Complexity           ?     408           
===========================================
  Files                ?      26           
  Lines                ?    2049           
  Branches             ?     180           
===========================================
  Hits                 ?    1420           
  Misses               ?     537           
  Partials             ?      92

codecov-io commented Jul 17, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (issue-182@6ad8d07). Click here to learn what that means.
The diff coverage is 75%.

@@             Coverage Diff             @@
##             issue-182    #186   +/-   ##
===========================================
  Coverage             ?   69.3%           
  Complexity           ?     408           
===========================================
  Files                ?      26           
  Lines                ?    2049           
  Branches             ?     180           
===========================================
  Hits                 ?    1420           
  Misses               ?     537           
  Partials             ?      92
@diemol

This comment has been minimized.

Show comment
Hide comment
@diemol

diemol Jul 18, 2017

Member

Hi @toshiya,

Thanks for this PR! I am on vacation now, I'll review it properly next week.

Member

diemol commented Jul 18, 2017

Hi @toshiya,

Thanks for this PR! I am on vacation now, I'll review it properly next week.

@diemol diemol changed the base branch from master to issue-182 Jul 25, 2017

@diemol

This comment has been minimized.

Show comment
Hide comment
@diemol

diemol Jul 25, 2017

Member

Hi @toshiya,

I'll merge this to a branch so I can add some documentation and then I'll merge to master.

Thanks!

Member

diemol commented Jul 25, 2017

Hi @toshiya,

I'll merge this to a branch so I can add some documentation and then I'll merge to master.

Thanks!

@diemol diemol merged commit af59b6c into zalando:issue-182 Jul 25, 2017

3 of 6 checks passed

codecov/project No report found to compare against
Details
codecov/patch 75% of diff hit (target 80%)
Details
zappr This PR needs 2 more approvals (0/2 given).
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr/pr/tasks PR has no open tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment