New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvement: video + docker-compose #92

Merged
merged 1 commit into from Apr 11, 2017

Conversation

4 participants
@AronNovak
Contributor

AronNovak commented Mar 30, 2017

About --abort-on-container-exit

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 30, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (logs@5a0011a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             logs      #92   +/-   ##
=======================================
  Coverage        ?   84.03%           
  Complexity      ?      291           
=======================================
  Files           ?       15           
  Lines           ?     1190           
  Branches        ?      119           
=======================================
  Hits            ?     1000           
  Misses          ?      135           
  Partials        ?       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0011a...f7dd132. Read the comment docs.

codecov-io commented Mar 30, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (logs@5a0011a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             logs      #92   +/-   ##
=======================================
  Coverage        ?   84.03%           
  Complexity      ?      291           
=======================================
  Files           ?       15           
  Lines           ?     1190           
  Branches        ?      119           
=======================================
  Hits            ?     1000           
  Misses          ?      135           
  Partials        ?       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0011a...f7dd132. Read the comment docs.

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Mar 30, 2017

Member

Thanks for the PR @AronNovak and for pointing out this problem.

Between yesterday and today we improved Zalenium so it waits for the video files to exist (while stopping) precisely to avoid this problem.

Can you pull latest and try again? we would love to see if this is solved and the documentation changes are no longer necessary.

Member

elgalu commented Mar 30, 2017

Thanks for the PR @AronNovak and for pointing out this problem.

Between yesterday and today we improved Zalenium so it waits for the video files to exist (while stopping) precisely to avoid this problem.

Can you pull latest and try again? we would love to see if this is solved and the documentation changes are no longer necessary.

@elgalu elgalu self-assigned this Mar 30, 2017

@AronNovak

This comment has been minimized.

Show comment
Hide comment
@AronNovak

AronNovak Apr 7, 2017

Contributor

Just tried it out now, as you can see on this Jenkins log: https://travis-ci.org/Gizra/drupal-elm-starter/jobs/219702104
I have the start-video, but not the stop-video counterpart.

Contributor

AronNovak commented Apr 7, 2017

Just tried it out now, as you can see on this Jenkins log: https://travis-ci.org/Gizra/drupal-elm-starter/jobs/219702104
I have the start-video, but not the stop-video counterpart.

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Apr 7, 2017

Member

Not sure if related but I see in the log:

test_server.sh: line 32: [: missing `]'

Member

elgalu commented Apr 7, 2017

Not sure if related but I see in the log:

test_server.sh: line 32: [: missing `]'

@AronNovak

This comment has been minimized.

Show comment
Hide comment
@AronNovak

AronNovak Apr 7, 2017

Contributor

@elgalu It's unrelated, we altered the condition to go always on the failing part, to test the video upload, it emits this warning but it just attempts to upload the video correctly.

Contributor

AronNovak commented Apr 7, 2017

@elgalu It's unrelated, we altered the condition to go always on the failing part, to test the video upload, it emits this warning but it just attempts to upload the video correctly.

@diemol

This comment has been minimized.

Show comment
Hide comment
@diemol

diemol Apr 7, 2017

Member

We'll check it on Monday, and after testing the command, I think we will merge.

Member

diemol commented Apr 7, 2017

We'll check it on Monday, and after testing the command, I think we will merge.

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu Apr 11, 2017

Member

👍

Member

elgalu commented Apr 11, 2017

👍

@diemol diemol changed the base branch from master to logs Apr 11, 2017

@diemol

This comment has been minimized.

Show comment
Hide comment
@diemol

diemol Apr 11, 2017

Member

👍

Member

diemol commented Apr 11, 2017

👍

@diemol diemol merged commit 680d22e into zalando:logs Apr 11, 2017

5 of 6 checks passed

codecov/project No report found to compare against
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zappr Approvals: @elgalu, @diemol.
zappr/pr/tasks PR has no open tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment