Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto completion for user selection dialogues are not consistent #2436

Open
MrGeneration opened this issue Jan 18, 2019 · 5 comments
Open

auto completion for user selection dialogues are not consistent #2436

MrGeneration opened this issue Jan 18, 2019 · 5 comments
Labels

Comments

@MrGeneration
Copy link
Member

Infos:

  • Used Zammad version: 2.8
  • Installation method (source, package, ..): any
  • Operating system: any
  • Database + version: any
  • Elasticsearch version: any
  • Browser + version: any

Expected behavior:

When handling customer data within Zammad, the agent/admin should always see the E-Mail-Address of the user, as you might not be able to find the correct user (without trying) if having more than one identical user.

This affects

  • New Ticket dialogue
  • Reply dialogue (via button)
  • Reply dialogue (manual)
  • Trigger and Scheduler

Actual behavior:

There are two ways how the auto completion and general look of customer information looks like when selecting customers, replying and forwarding. This is not consequent and -especially on creating new tickets- might cause confusion and more work than it should be.

Examples

This is how Customer and CC looks like when creating a new ticket:
image

This is what it looks like when pressing on "reply":
image

Manually entering E-Mail-Adresses within replying on a ticket is consequent (and how it should be):
image

Kinda optional but when we're working on consistent UI stuff, this should also apply schedulers and triggers:
image

Wanted stuff

The e-mail address should appear behind the user name, the to field (especially when pressing on "reply" should contain the FROM-Name.

Yes I'm sure this is a bug and no feature request or a general question.

@martinvonwittich
Copy link
Contributor

Related issue: #2275

martinvonwittich added a commit to martinvonwittich/zammad that referenced this issue Jan 26, 2019
@martinvonwittich
Copy link
Contributor

I decided that this would be a good starting point to figure out how to hack Zammad, so I've attempted to fix this issue myself: martinvonwittich@5826ee8

This displays the email address of the customer in the following places:

  • New Ticket dialogue
  • Trigger and Scheduler

but not in the reply dialogues. I haven't yet been able to figure out how those work :/

I've decided just to use the same style that's already used for the organization, but I've added a new CSS class .recipientList-email for that purpose so that it can be easily styled differently, if necessary.

Do I need to do anything else? Does this require writing tests? Sorry, completely new to this :)

@MrGeneration
Copy link
Member Author

Hey Felix,

could you please take a look at this? :)

@martinvonwittich
Copy link
Contributor

Should I just go ahead and create a merge request to speed this up? ^^

@MrGeneration
Copy link
Member Author

Hey Martin,

if you have time for this a crontribution / MR would be amazing. :-)

martinvonwittich added a commit to martinvonwittich/zammad that referenced this issue Mar 30, 2019
@dominikklein dominikklein added 🚧 refactoring 2.0 🚧 This refactor of this issue requires Zammads UI refactor to be done. enhancement and removed bug labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants