Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts in different keyboard layout #656

Open
tojaskiba opened this issue Jan 20, 2017 · 14 comments
Open

Shortcuts in different keyboard layout #656

tojaskiba opened this issue Jan 20, 2017 · 14 comments

Comments

@tojaskiba
Copy link
Contributor

@tojaskiba tojaskiba commented Jan 20, 2017

  • Used Zammad version: 1.2.0
  • Operating system: Windows 7 Proffesional
  • Browser + version: Chromium 57
  • Ticket-ID: #1048406

When using Polish keyboard, using special character like ę with alt+e triggers logout shortcut.
Maybe zammad should use ctrl + shift?

@tojaskiba

This comment has been minimized.

Copy link
Contributor Author

@tojaskiba tojaskiba commented Jan 25, 2017

What is the best way to turn off shortcuts system wide? Maybe such option should appear also in every user's profile settings menu?

@maege

This comment has been minimized.

Copy link

@maege maege commented Feb 6, 2017

Same Problem by typing @ in swiss german layout -> (Ctrl + Alt + 2) will result in h2 title.

@tojaskiba

This comment has been minimized.

Copy link
Contributor Author

@tojaskiba tojaskiba commented Feb 27, 2017

i fixed this in our installation by changing line 127 in app/assets/javascripts/app/lib/base/jquery.contenteditable.js
from e.altKey to e.shiftKey

@martini

This comment has been minimized.

Copy link
Collaborator

@martini martini commented Apr 9, 2017

The current idea is to move to different shortcuts for windows/mac:

mac: ctrl+alt
windows: ctrl+shift

Any feedback about this? @johan12345

@martini martini self-assigned this Apr 9, 2017
@johan12345

This comment has been minimized.

Copy link
Contributor

@johan12345 johan12345 commented Apr 9, 2017

Yeah, changing to Ctrl+Shift would probably be more conflict-free solution than the current one. Some shortcuts could even be done just with Ctrl (for example, Ctrl+B, Ctrl+U, Ctrl+I are quite common for text formatting, and the same thing on Mac with Cmd+B, Cmd+U, Cmd+I).

The most flexible way would of course be to make the shortcuts user-configurable, but that's also more time-consuming to implement.

@monotek

This comment has been minimized.

Copy link
Member

@monotek monotek commented Apr 9, 2017

@martini
Why not "ctrl + shift" everywhere?

zammad-sync pushed a commit that referenced this issue Apr 10, 2017
@martini

This comment has been minimized.

Copy link
Collaborator

@martini martini commented Apr 10, 2017

for example, Ctrl+B, Ctrl+U, Ctrl+I are quite common for text formatting, and the same thing on Mac with Cmd+B, Cmd+U, Cmd+I

Thanks a good idea! Done.

Why not "ctrl + shift" everywhere?

There are some native mac shortcuts on mac with ctrl+shift which conflict then.

Shortcuts are now dependent on OS (in develop branch). Feedback if there are still conflicts would be good!

Mac:
screen shot 2017-04-10 at 00 01 45

Win/Linux:
screen shot 2017-04-09 at 23 53 04

@martini martini closed this Apr 11, 2017
@martini martini added this to the 1.5.0 milestone Apr 18, 2017
rolfschmidt referenced this issue Apr 18, 2017
…s which would open url of old closed tabs.
@zabarabab

This comment has been minimized.

Copy link

@zabarabab zabarabab commented Apr 24, 2017

ctrl-shift-w closes firefox on linux ;-(

@zabarabab zabarabab reopened this Apr 24, 2017
@tojaskiba

This comment has been minimized.

Copy link
Contributor Author

@tojaskiba tojaskiba commented Apr 26, 2017

Right, ctrl+shift is base of many browser shortcuts

@rolfschmidt rolfschmidt self-assigned this May 5, 2017
@maege

This comment has been minimized.

Copy link

@maege maege commented May 8, 2017

Hi
We have no issues with the new shortcuts. Thank you :-)
I think a other nice shortcut is: Ctrl + Enter for sending E-Mail or Article like Outlook:
image
Outlook prevents accidental sending with the the sending with the warning above (you can just press enter to accept the warning and send the mail)

@AND51

This comment has been minimized.

Copy link

@AND51 AND51 commented May 26, 2017

Dear all,
Dear rolfschmidt,

According to rolfschmidt in #1052, I would like to express my opinion here. I consider "shortcut issues" a difficult topic, because of all these github issues regarding that topic. Also, I apologize in advance, if sombody has already said what I want to say now.

I mainly use two browsers, Firefox and Vivaldi. I work with Zendesk a lot and – it's a miracle – Zendesk hardly collides with browser-shortcuts. I don't know why :-D
However, the combination of Firefox/Zammad and especially Vivaldi/Zammad is quite different.

I like the way you can configure the shortcuts in Vivaldi. I think, this is also a reasonable way for Zammad. Plus, the Zammad-team can deliver Zammad with a collection of "best practice shortcuts". People may configure other shortcuts (globally or per account), if they need to.

Here is what the shortcut screen looks like in Vivaldi, but I'm sure you have already seen this in other applications, too:

image

@thorsteneckel

This comment has been minimized.

Copy link
Collaborator

@thorsteneckel thorsteneckel commented May 28, 2017

I like the way you can configure the shortcuts in Vivaldi. I think, this is also a reasonable way for Zammad. Plus, the Zammad-team can deliver Zammad with a collection of "best practice shortcuts". People may configure other shortcuts (globally or per account), if they need to.

++

@pinscher

This comment has been minimized.

Copy link

@pinscher pinscher commented Jan 10, 2019

It makes no sense to use shift+ctrl on windows because shift+ctrl is used already by many browser shortcuts (chrome, firefox). Zendesk is using on windows Strg+Alt instead. This is much better cause there are no browser shortscuts existing for Strg+Alt.

Also thre must be a shortcut to change the state, e.g. like in Zendesk:
image

@blizzz

This comment has been minimized.

Copy link

@blizzz blizzz commented Dec 13, 2019

I accidentally triggered the "update as closed" function several times when I only wanted to copy text. Ctrl+Shift+C is copying on terminal. Of course I am in the browser now, yet muscle memory comes into play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.