Skip to content
This repository has been archived by the owner. It is now read-only.

Remove untranslated and total from contribution stats #21

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@aeng
Copy link
Member

commented Nov 16, 2014

No description provided.

/**
* @author Alex Eng <a href="mailto:aeng@redhat.com">aeng@redhat.com</a>
*/
@JsonIgnoreProperties(value = {"untranslated", "total"})

This comment has been minimized.

Copy link
@carlosmunoz

carlosmunoz Nov 16, 2014

Member

Not sure about this. Sure, the Json representation works, but you get a couple of extra fields in the object that makes the code reading a bit more complicated. I would say we're better off duplicating those fields for this object.

@carlosmunoz

This comment has been minimized.

Copy link
Member

commented Nov 16, 2014

Review complete. See comments.

@carlosmunoz

This comment has been minimized.

Copy link
Member

commented Nov 16, 2014

👍 Reviewed

@aeng

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2014

Merged into integration/master. fb41d05

@aeng aeng closed this Nov 17, 2014

@aeng aeng deleted the rhbz1092193 branch Nov 17, 2014

@aeng aeng restored the rhbz1092193 branch Nov 19, 2014

@aeng aeng deleted the rhbz1092193 branch Nov 20, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.