Fixed the --excludes option

[Benaan]

The CLI client produced the following error when doing a push command which uses the --excludes option. The --includes option doesn't cause this error.

java.lang.UnsupportedOperationException
at java.util.AbstractList.add(AbstractList.java:148)
at java.util.AbstractList.add(AbstractList.java:108)
at org.zanata.client.commands.push.AbstractPushStrategy.addExcludesForLocaleFilenames(AbstractPushStrategy.java:112)
at org.zanata.client.commands.push.AbstractPushStrategy.getSrcFiles(AbstractPushStrategy.java:98)
at org.zanata.client.commands.push.PropertiesStrategy.findDocNames(PropertiesStrategy.java:80)
at org.zanata.client.commands.push.PushCommand.pushCurrentModule(PushCommand.java:280)
at org.zanata.client.commands.push.PushCommand.run(PushCommand.java:203)
at org.zanata.client.commands.ConfigurableCommand.runWithActions(ConfigurableCommand.java:94)
at org.zanata.client.commands.ArgsUtil.runCommand(ArgsUtil.java:48)
at org.zanata.client.ZanataClient.processArgs(ZanataClient.java:168)
at org.zanata.client.ZanataClient.main(ZanataClient.java:93)

[zanata-jenkins]

Can one of the admins verify this patch?

[buildhive]

Zanata » zanata-client #174 SUCCESS
This pull request looks good
(what's this?)

[alex-sl-eng]

I don't think this is the main cause/fix of the issue. Field should be set to new value in Setter method. We should check what is the exact exception in AbstractPushStrategy.java:112.

[carlosmunoz]

I agree with @aeng here in that a setter should not be adding elements to the existing list.
Perhaps the right change should be to wrap the split call around a new concrete list:

this.excludes = new ArrayList( StringUtil.split(excludes, ",") )

The problem seems to be that the excludes list is being set to an unmodifiable list, that later down the code is being reused and modified.
@Benaan Could you provide a test case or at least describe your environment (OS, Java version, etc.) and the exact command line you were running when you saw this?

[Benaan]

The problem is indeed that setExcludes creates an unmodifiable list. I've tested your solution and it also fixes the error.

My environment is:
Debian 7.4 (wheezy)
Oracle Java 7u55

I've tested with both the latest master version and the 3.3.0 release. Both produce the error.

The command I've used to test this:

zanata-cli -B -e push --excludes **/log4j.properties -s . -t .

[seanf]

@Benaan would you mind checking out #20? This problem is really about the code not being clear about what's mutable and what's not, so I have used ImmutableSet/List where possible, and adapted the logic to suit.

[seanf]

Replaced by #20 and #22.

Thanks @Benaan.