Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

rhbz1174516 - enable more flexible file mappings rules in podir project #40

Merged
merged 2 commits into from Dec 23, 2014

Conversation

huangp
Copy link
Collaborator

@huangp huangp commented Dec 16, 2014

  • when push, podir project can no longer rely on translation files having locale as a directory

@carlosmunoz
Copy link
Member

Are there any other strategies that we might need to modify for the same reason?

@huangp
Copy link
Collaborator Author

huangp commented Dec 16, 2014

Only Gettext may still have this problem. But we need to know what's the role of project type. e.g. gettext project and podir, the difference between these two are really the translation file convention. Now that we allow arbitrary file mapping rules, which means, these two project type can be combined into one.

Podir: convention is to have local as directory. i.e. source dir "pot", file about-fedora.pot, trans-dir ".", translation will be put as ./de/about-fedora.po
Gettext: convention is to have locale as filename. i.e. source file gcc.pot, trans file de.po

The man page l10n project is NOT a typical podir project nor a gettext project. It's more like a group of podir projects together. Unfortunately file type project don't support pushing pot using client yet otherwise it makes more sense to make project type 'file'.

Gettext project still assume locale as file name. I think gettext is more strict on directory structure. This PR has loosen up Podir's expectation. It should be enough to cover the odd cases like this.

All other project types do not seem to have this problem.

----- Original Message -----

From: "Carlos Munoz" notifications@github.com
To: "zanata/zanata-client" zanata-client@noreply.github.com
Cc: "Patrick Huang" pahuang@redhat.com
Sent: Tuesday, December 16, 2014 4:05:29 PM
Subject: Re: [zanata-client] rhbz1174516 - enable more flexible file mappings
rules in podir project (#40)

Are there any other strategies that we might need to modify for the same
reason?


Reply to this email directly or view it on GitHub .

@huangp huangp force-pushed the rhbz1174516-podir-filemapping branch from 5d00931 to 50a4028 Compare December 16, 2014 06:42
@huangp
Copy link
Collaborator Author

huangp commented Dec 16, 2014

I was wrong about gettext project. I should also change it so that push and pull are in sync.

@huangp huangp force-pushed the rhbz1174516-podir-filemapping branch from 50a4028 to 3d5605b Compare December 16, 2014 23:47
…ettext project

- when push, podir project will log warning on locales don't have any translation file but won't rely on directory convention
- when push, gettext project will log warning on po file missing locale but won't rely on file name convention
@huangp huangp force-pushed the rhbz1174516-podir-filemapping branch from 3d5605b to 20970d2 Compare December 17, 2014 00:13
@huangp
Copy link
Collaborator Author

huangp commented Dec 17, 2014

Ready for review again

@carlosmunoz
Copy link
Member

👍 Reviewed previous commits.

@seanf seanf assigned carlosmunoz and unassigned seanf Dec 17, 2014
@huangp huangp force-pushed the rhbz1174516-podir-filemapping branch 2 times, most recently from 192a71b to 1ef4bdb Compare December 22, 2014 23:51
…(i.e. auto)

- if after the stripping there is no entries left, we can skip the REST call for that translation file
@definite
Copy link
Member

huangp pushed a commit that referenced this pull request Dec 23, 2014
rhbz1174516 - enable more flexible file mappings rules in podir project
@huangp huangp merged commit 29cbd7e into release Dec 23, 2014
@huangp huangp deleted the rhbz1174516-podir-filemapping branch December 23, 2014 04:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants