fix: limit description length for tmx

https://zanata.atlassian.net/browse/ZNTA-2088
zanata · Jul 19, 2017 · 1dfa940 · 1dfa940
1 parent 8ea283a
commit 1dfa940
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/server/zanata-model/src/main/java/org/zanata/model/tm/TransMemory.java b/server/zanata-model/src/main/java/org/zanata/model/tm/TransMemory.java
@@ -34,6 +34,8 @@
 import javax.persistence.MapKeyColumn;
 import javax.persistence.MapKeyEnumerated;
 import javax.persistence.OneToMany;
+import javax.validation.constraints.Size;
+
 import org.zanata.model.SlugEntityBase;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
@@ -49,6 +51,7 @@
 public class TransMemory extends SlugEntityBase implements HasTMMetadata {
     private static final long serialVersionUID = 1L;
     @Column(columnDefinition = "longtext")
+    @Size(max = 100)
     private String description;
     // This is the BCP-47 language code. Null means any source language (*all*
     // in TMX)

diff --git a/server/zanata-war/src/main/resources/db/changelogs/db.changelog-4.2.xml b/server/zanata-war/src/main/resources/db/changelogs/db.changelog-4.2.xml
@@ -159,4 +159,10 @@
     <addPrimaryKey tableName="HTextFlowTargetContentHistory" columnNames="pos,text_flow_target_history_id"/>
   </changeSet>
 
+  <changeSet id="1" author="aeng@redhat.com">
+    <comment>Alter TransMemory description, limit max length</comment>
+    <sql>UPDATE TransMemory SET description=SUBSTRING(description,1,100);</sql>
+    <modifyDataType tableName="TransMemory" columnName="description"
+        newDataType="char(100)"/>
+  </changeSet>
 </databaseChangeLog>
diff --git a/server/zanata-war/src/main/webapp/WEB-INF/layout/transmemory_edit_form.xhtml b/server/zanata-war/src/main/webapp/WEB-INF/layout/transmemory_edit_form.xhtml
@@ -2,8 +2,28 @@
   xmlns="http://www.w3.org/1999/xhtml"
   xmlns:ui="http://java.sun.com/jsf/facelets"
   xmlns:zanata="http://java.sun.com/jsf/composite/zanata"
+  xmlns:f="http://java.sun.com/jsf/core"
   xmlns:h="http://java.sun.com/jsf/html"
-  xmlns:a4j="http://richfaces.org/a4j">
+  xmlns:a4j="http://richfaces.org/a4j"
+  xmlns:rich="http://richfaces.org/rich">
+
+  <script>
+    function getDescriptionMessageCountField() {
+      return jQuery('#' + jqSelector('#{rich:clientId('trans-memory-desc-count')}'));
+    }
+
+    function validateDescriptionField(textArea) {
+      var len = 100 - textArea.value.length;
+      getDescriptionMessageCountField().text('Characters left: ' + len);
+      if (textArea.value.length > 100) {
+        getDescriptionMessageCountField().addClass("txt--danger");
+        getDescriptionMessageCountField().parent('div').addClass("form__item--error")
+      } else {
+        getDescriptionMessageCountField().removeClass("txt--danger");
+        getDescriptionMessageCountField().parent('div').removeClass("form__item--error")
+      }
+    }
+  </script>
 
   <div class="l--push-top-half form__item">
     <h:outputLabel for="slug">#{msgs['jsf.transmemory.TransMemoryId']}
@@ -24,7 +44,11 @@
     <h:outputLabel for="description">#{msgs['jsf.Description']}</h:outputLabel>
     <zanata:decorate id="description" componentId="descriptionField">
       <h:inputTextarea id="description" required="false"
-        value="#{translationMemoryHome.instance.description}"/>
+        value="#{translationMemoryHome.instance.description}"
+        onkeyup="validateDescriptionField(this)">
+        <f:validateLength maximum="100"/>
+      </h:inputTextarea>
+      <h:outputLabel id="trans-memory-desc-count" styleClass="txt--meta"></h:outputLabel>
     </zanata:decorate>
   </div>