diff --git a/build-tools/src/main/resources/zanata-build-tools/versions-rules.xml b/build-tools/src/main/resources/zanata-build-tools/versions-rules.xml
new file mode 100644
index 0000000000..c4e47caf9e
--- /dev/null
+++ b/build-tools/src/main/resources/zanata-build-tools/versions-rules.xml
@@ -0,0 +1,8 @@
+
+
+
+ .*[-_\.](alpha|Alpha|ALPHA|b|beta|Beta|BETA|cr|CR|rc|RC|M|EA)[-_\.]?[0-9]*
+
+
diff --git a/parent/pom.xml b/parent/pom.xml
index b2583cd3ed..a2eec5884d 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -596,7 +596,17 @@
org.codehaus.mojo
versions-maven-plugin
- 2.2
+ 2.5
+
+ classpath:///zanata-build-tools/versions-rules.xml
+
+
+
+ org.zanata
+ build-tools
+ ${project.version}
+
+
@@ -843,6 +853,19 @@
+
+ org.sonatype.plugins
+ nexus-staging-maven-plugin
+ 1.1
+ true
+
+
+ https://oss.sonatype.org/
+
+ sonatype-staging
+
+
+
org.apache.maven.plugins
diff --git a/server/gwt-shared/src/main/java/org/zanata/webtrans/shared/rest/dto/TransReviewCriteria.java b/server/gwt-shared/src/main/java/org/zanata/webtrans/shared/rest/dto/TransReviewCriteria.java
index 124fafae31..d2953c8ee0 100644
--- a/server/gwt-shared/src/main/java/org/zanata/webtrans/shared/rest/dto/TransReviewCriteria.java
+++ b/server/gwt-shared/src/main/java/org/zanata/webtrans/shared/rest/dto/TransReviewCriteria.java
@@ -35,17 +35,17 @@ public class TransReviewCriteria implements IsSerializable, Serializable {
private Long id;
private IssuePriority priority;
private String description;
- private boolean editable;
+ private boolean commentRequired;
public TransReviewCriteria() {
}
public TransReviewCriteria(Long id, IssuePriority priority, String description,
- boolean editable) {
+ boolean commentRequired) {
this.id = id;
this.priority = priority;
this.description = description;
- this.editable = editable;
+ this.commentRequired = commentRequired;
}
@@ -57,8 +57,8 @@ public String getDescription() {
return description;
}
- public boolean isEditable() {
- return editable;
+ public boolean isCommentRequired() {
+ return commentRequired;
}
public Long getId() {
diff --git a/server/services/src/main/java/org/zanata/rest/review/ReviewService.java b/server/services/src/main/java/org/zanata/rest/review/ReviewService.java
index 61a94e52d9..3e0156c401 100644
--- a/server/services/src/main/java/org/zanata/rest/review/ReviewService.java
+++ b/server/services/src/main/java/org/zanata/rest/review/ReviewService.java
@@ -80,7 +80,7 @@ protected ReviewService(ReviewCriteriaDAO reviewCriteriaDAO, UriInfo uriInfo, Ur
public static TransReviewCriteria fromModel(ReviewCriteria criteria) {
return new TransReviewCriteria(criteria.getId(), criteria.getPriority(),
- criteria.getDescription(), criteria.isEditable());
+ criteria.getDescription(), criteria.isCommentRequired());
}
@POST
@@ -94,7 +94,7 @@ public Response addCriteria(TransReviewCriteria criteria) {
}
ReviewCriteria reviewCriteria =
new ReviewCriteria(criteria.getPriority(),
- criteria.isEditable(), criteria.getDescription());
+ criteria.isCommentRequired(), criteria.getDescription());
reviewCriteriaDAO.makePersistent(reviewCriteria);
return Response.created(UriBuilder.fromUri(urlUtil.restPath(
uriInfo.getPath())).path(reviewCriteria.getId().toString()).build())
@@ -117,7 +117,7 @@ public Response editCriteria(@PathParam("id") Long id, TransReviewCriteria crite
return Response.status(Response.Status.NOT_FOUND).build();
}
reviewCriteria.setDescription(criteria.getDescription());
- reviewCriteria.setEditable(criteria.isEditable());
+ reviewCriteria.setCommentRequired(criteria.isCommentRequired());
reviewCriteria.setPriority(criteria.getPriority());
return Response.ok(fromModel(reviewCriteria)).build();
}
diff --git a/server/services/src/main/resources/db/changelogs/db.changelog-4.5.xml b/server/services/src/main/resources/db/changelogs/db.changelog-4.5.xml
new file mode 100644
index 0000000000..b9c6910150
--- /dev/null
+++ b/server/services/src/main/resources/db/changelogs/db.changelog-4.5.xml
@@ -0,0 +1,25 @@
+
+
+
+
+
+ Rename editable to commentRequired
+
+
+
+ Make commentRequired non-null
+
+ update ReviewCriteria set commentRequired = false where commentRequired is null;
+
+
+
+ Make commentRequired non-nullable
+
+
+
+
diff --git a/server/services/src/main/resources/db/db.changelog.xml b/server/services/src/main/resources/db/db.changelog.xml
index d0964b384f..ea81060191 100644
--- a/server/services/src/main/resources/db/db.changelog.xml
+++ b/server/services/src/main/resources/db/db.changelog.xml
@@ -51,6 +51,8 @@
file="changelogs/db.changelog-4.3.xml" />
+