rhbz873509 - Selected message in editor should scroll fully into view

zanata · Nov 9, 2012 · 08e094a · 08e094a
1 parent 9c96e58
commit 08e094a
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 0 deletions.
diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java b/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TargetContentsPresenter.java
@@ -581,6 +581,11 @@ else if (!Objects.equal(contentsDisplay.getCachedTargets(), contentsDisplay.getN
       }
    }
 
+   public TargetContentsDisplay getCurrentDisplay()
+   {
+      return display;
+   }
+
    /**
     * For testing only
     * @param currentTransUnitId current trans unit id

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TransUnitsTablePresenter.java b/zanata-war/src/main/java/org/zanata/webtrans/client/presenter/TransUnitsTablePresenter.java
@@ -152,6 +152,7 @@ public void onTransUnitSelected(TransUnitSelectionEvent event)
       Log.debug("selected id: " + selectedId);
       sourceContentsPresenter.setSelectedSource(selectedId);
       targetContentsPresenter.setSelected(selectedId);
+      display.ensureVisible(targetContentsPresenter.getCurrentDisplay());
       translatorService.transUnitSelected(selection);
    }
 

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransUnitsTableDisplay.java b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransUnitsTableDisplay.java
@@ -49,6 +49,8 @@ public interface TransUnitsTableDisplay extends WidgetDisplay
 
    void delayRefresh();
 
+   void ensureVisible(TargetContentsDisplay currentDisplay);
+
    interface Listener
    {
       void onRowSelected(int rowIndex);

diff --git a/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransUnitsTableView.java b/zanata-war/src/main/java/org/zanata/webtrans/client/view/TransUnitsTableView.java
@@ -178,6 +178,12 @@ public void delayRefresh()
       timer.schedule(100);
    }
 
+   @Override
+   public void ensureVisible(TargetContentsDisplay currentDisplay)
+   {
+      root.ensureVisible(currentDisplay.asWidget());
+   }
+
    @Override
    public void setRowSelectionListener(Listener listener)
    {

diff --git a/...-war/src/test/java/org/zanata/webtrans/client/presenter/TransUnitsTablePresenterTest.java b/...-war/src/test/java/org/zanata/webtrans/client/presenter/TransUnitsTablePresenterTest.java
@@ -112,6 +112,7 @@ public void onTransUnitSelected()
       verify(sourceContentsPresenter).setSelectedSource(selection.getId());
       verify(targetContentsPresenter).setSelected(selection.getId());
       verify(translatorService).transUnitSelected(selection);
+      verify(display).ensureVisible(targetContentsPresenter.getCurrentDisplay());
    }
 
    @Test