From 4b9cc896a01e3b9a69325556cad32d3c04781d00 Mon Sep 17 00:00:00 2001 From: Patrick Huang Date: Thu, 3 Oct 2013 09:08:13 +1000 Subject: [PATCH] change google signin to take credential from property --- .../src/test/java/org/zanata/util/GoogleSignIn.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/functional-test/src/test/java/org/zanata/util/GoogleSignIn.java b/functional-test/src/test/java/org/zanata/util/GoogleSignIn.java index 845e23bd85..0ab63d9500 100644 --- a/functional-test/src/test/java/org/zanata/util/GoogleSignIn.java +++ b/functional-test/src/test/java/org/zanata/util/GoogleSignIn.java @@ -20,6 +20,7 @@ */ package org.zanata.util; +import com.google.common.base.Strings; import lombok.extern.slf4j.Slf4j; import java.io.IOException; @@ -53,9 +54,11 @@ public static boolean googleIsReachable() { } /** - * Query the environment for a GOOGLEID variable and return the stated + * Query the property for a GOOGLEID variable and return the stated * password that corresponds to the indicated username. Expects the variable - * to be in the form: GOOGLEID=username1:password1;username2:password2;... + * to be in the form: + *

+ * {@literal mvn -DGOOGLEID=username1:password1;username2:password2;} * * @param username * Username of username:password pair query @@ -65,8 +68,9 @@ public static boolean googleIsReachable() { public static String getSignIn(String username) { String googlePass; String empty = ""; - googlePass = System.getenv("GOOGLEID"); - if (googlePass == null || googlePass.isEmpty()) { + googlePass = System.getProperty("GOOGLEID"); + if (Strings.isNullOrEmpty(googlePass)) { + log.info("Google open ID credential is not available"); return empty; }