From d2027b4f94ff8c2b5b929ef3cfef238ea7a905f7 Mon Sep 17 00:00:00 2001 From: "Carlos A. Munoz" Date: Mon, 12 Aug 2013 10:11:15 +1000 Subject: [PATCH 1/4] Update zanata public package script to new JBoss AS 7 config. --- .../layers/base/sun/jdk/main/module.xml | 97 ++++++ .../server/zanata/conf/login-config.xml | 141 -------- .../server/zanata/conf/zanata.properties | 16 - .../standalone/configuration/standalone.xml | 329 ++++++++++++++++++ .../etc/scripts/zanata-server-package.sh | 30 +- zanata-war/src/etc/zanata-ds.xml | 227 +----------- 6 files changed, 454 insertions(+), 386 deletions(-) create mode 100644 zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml delete mode 100644 zanata-war/etc/public-package/server/zanata/conf/login-config.xml delete mode 100644 zanata-war/etc/public-package/server/zanata/conf/zanata.properties create mode 100644 zanata-war/etc/public-package/standalone/configuration/standalone.xml diff --git a/zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml b/zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml new file mode 100644 index 0000000000..2dcef2efb1 --- /dev/null +++ b/zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml @@ -0,0 +1,97 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/zanata-war/etc/public-package/server/zanata/conf/login-config.xml b/zanata-war/etc/public-package/server/zanata/conf/login-config.xml deleted file mode 100644 index dcca56ae92..0000000000 --- a/zanata-war/etc/public-package/server/zanata/conf/login-config.xml +++ /dev/null @@ -1,141 +0,0 @@ - - - - - - - - - - - true - - - - - - - - - sa - sa - - jboss.jca:service=LocalTxCM,name=DefaultDS - - - - - - - - guest - guest - guest - jboss.jca:service=TxCM,name=JmsXA - - - - - - - - - props/jmx-console-users.properties - props/jmx-console-roles.properties - - - - - - - - - web-console-users.properties - web-console-roles.properties - - - - - - - - - props/jbossws-users.properties - props/jbossws-roles.properties - anonymous - - - - - - - - - - - - - - - - - - - - - diff --git a/zanata-war/etc/public-package/server/zanata/conf/zanata.properties b/zanata-war/etc/public-package/server/zanata/conf/zanata.properties deleted file mode 100644 index 4429e67616..0000000000 --- a/zanata-war/etc/public-package/server/zanata/conf/zanata.properties +++ /dev/null @@ -1,16 +0,0 @@ -# Zanata general configuration properties. -# -# Make sure this file is available on the server classpath when deploying. -# (A good place is JBOSS_HOME/server//conf) -# If not, an Zanata won't be able to start - -# Zanata Authentication Policy names -# The property key indicates the authentication type and the value -# is the name of the security policy in login-config.xml -# (Only one can be selected, excepted for internal and openid which -# can be active simultaneously) -# Valid key values: zanata.security.auth.policy.internal, .kerberos, .openid, .jaas -zanata.security.auth.policy.internal = zanata - -# Users that should be made administrators upon bootstrap or registration. -#zanata.security.admin.users = admin \ No newline at end of file diff --git a/zanata-war/etc/public-package/standalone/configuration/standalone.xml b/zanata-war/etc/public-package/standalone/configuration/standalone.xml new file mode 100644 index 0000000000..a48708d822 --- /dev/null +++ b/zanata-war/etc/public-package/standalone/configuration/standalone.xml @@ -0,0 +1,329 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + jdbc:h2:mem:test;DB_CLOSE_DELAY=-1 + h2 + + sa + sa + + + + + org.h2.jdbcx.JdbcDataSource + + + + + + + + + false + true + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + true + ${jboss.bind.address:127.0.0.1} + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/zanata-war/etc/scripts/zanata-server-package.sh b/zanata-war/etc/scripts/zanata-server-package.sh index ac06069de9..144a18f21f 100755 --- a/zanata-war/etc/scripts/zanata-server-package.sh +++ b/zanata-war/etc/scripts/zanata-server-package.sh @@ -4,10 +4,10 @@ # Author: camunoz@redhat.com # This script prepares a Zanata standalone server package -# based on JBoss 5 Community version. +# based on JBoss 7.2.0 AS Community version. # # Parameters: -# 1. JBoss 5 zip distribution location. +# 1. JBoss 7 zip distribution location. # # Pre-requisites: # 1. Apache maven in the path @@ -15,7 +15,7 @@ # Mysql Driver version to be used MYSQL_DRV_VERSION=5.1.18 -# Get the JBoss 5 zip location from parameters +# Get the JBoss 7 zip location from parameters JBOSS_ZIP_LOC=$1 JBOSS_ZIP_PARENT=${JBOSS_ZIP_LOC%/*} @@ -37,39 +37,29 @@ JBOSS_TMP_DIR=$TMP_DIR/$(ls $TMP_DIR | sort -n | head -1) # Remove unnecessary files from the package echo 'Customizing JBoss release...' -rm -rf $JBOSS_TMP_DIR/client +rm -rf $JBOSS_TMP_DIR/bin/client rm -rf $JBOSS_TMP_DIR/docs -rm -rf $JBOSS_TMP_DIR/server/all -rm -rf $JBOSS_TMP_DIR/server/minimal -rm -rf $JBOSS_TMP_DIR/server/standard -rm -rf $JBOSS_TMP_DIR/server/web -rm -rf $JBOSS_TMP_DIR/server/default/deploy/admin-console.war -rm -rf $JBOSS_TMP_DIR/server/default/deploy/jmx-console.war -rm -rf $JBOSS_TMP_DIR/server/default/deploy/ROOT.war - -# Rename files -mv $JBOSS_TMP_DIR/server/default $JBOSS_TMP_DIR/server/zanata # Add Zanata specific files -cp $ZANATA_WAR_HOME/target/zanata-*.war $JBOSS_TMP_DIR/server/zanata/deploy/zanata.war -cp $ZANATA_WAR_HOME/src/etc/zanata-ds.xml $JBOSS_TMP_DIR/server/zanata/deploy +cp $ZANATA_WAR_HOME/target/zanata-*.war $JBOSS_TMP_DIR/standalone/deployments/zanata.war +cp $ZANATA_WAR_HOME/src/etc/zanata-ds.xml $JBOSS_TMP_DIR//standalone/deployments cp -r $ZANATA_WAR_HOME/etc/public-package/* $JBOSS_TMP_DIR/ # Get Maven dependencies mvn dependency:get -DrepoUrl=http://repo1.maven.org -Dartifact=mysql:mysql-connector-java:$MYSQL_DRV_VERSION -cp ~/.m2/repository/mysql/mysql-connector-java/$MYSQL_DRV_VERSION/mysql-connector-java-$MYSQL_DRV_VERSION.jar $JBOSS_TMP_DIR/server/zanata/lib +cp ~/.m2/repository/mysql/mysql-connector-java/$MYSQL_DRV_VERSION/mysql-connector-java-$MYSQL_DRV_VERSION.jar $JBOSS_TMP_DIR/standalone/deployments/mysql-connector-java.jar # Create zanata start scripts echo "# Zanata start script" >> $JBOSS_TMP_DIR/bin/start-zanata.sh -echo "./run.sh -c zanata" >> $JBOSS_TMP_DIR/bin/start-zanata.sh -echo "run.bat -c zanata" >> $JBOSS_TMP_DIR/bin/start-zanata.bat +echo "./standalone.sh" >> $JBOSS_TMP_DIR/bin/start-zanata.sh +echo "standalone.bat" >> $JBOSS_TMP_DIR/bin/start-zanata.bat chmod a+x $JBOSS_TMP_DIR/bin/start-zanata.sh # Rename the JBoss temporary directory mv $JBOSS_TMP_DIR $TMP_DIR/zanata-server-$zanata_version -# Pack the war again +# Pack the distribution echo 'Building distributable archive...' cd $TMP_DIR zip -rq zanata-server-${zanata_version}.zip zanata-server-$zanata_version diff --git a/zanata-war/src/etc/zanata-ds.xml b/zanata-war/src/etc/zanata-ds.xml index 1117fce260..7933235a0b 100644 --- a/zanata-war/src/etc/zanata-ds.xml +++ b/zanata-war/src/etc/zanata-ds.xml @@ -1,212 +1,21 @@ - - - - zanataDatasource - jdbc:mysql://localhost:3306/zanata?characterEncoding=UTF-8 - com.mysql.jdbc.Driver - ${mysql.user} - ${mysql.password} - - - + + + + jdbc:mysql://localhost:3306/zanata?characterEncoding=UTF-8 + mysql-connector-java.jar + + root + + + + \ No newline at end of file From b42c7eaf9b110878c41e49f594bc18dea443cf55 Mon Sep 17 00:00:00 2001 From: "Carlos A. Munoz" Date: Mon, 26 Aug 2013 08:48:08 +1000 Subject: [PATCH 2/4] Change the way the public package is built. Now uses .patch files to make modifications. --- .gitignore | 3 + zanata-war/etc/public-package/README.txt | 2 +- .../layers/base/sun/jdk/main/module.xml | 97 ------ .../etc/public-package/patches/as7.patch | 64 ++++ .../standalone/configuration/standalone.xml | 329 ------------------ .../etc/scripts/zanata-server-package.sh | 4 +- 6 files changed, 70 insertions(+), 429 deletions(-) delete mode 100644 zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml create mode 100644 zanata-war/etc/public-package/patches/as7.patch delete mode 100644 zanata-war/etc/public-package/standalone/configuration/standalone.xml diff --git a/.gitignore b/.gitignore index 76cbea3187..fd98cb7b21 100644 --- a/.gitignore +++ b/.gitignore @@ -6,6 +6,9 @@ *~ *.patch +# Include patches used for the publick package +!/zanata-war/etc/public-package/patches/**/*.patch + *.sedbak zanatasearchindex/ test-output/ diff --git a/zanata-war/etc/public-package/README.txt b/zanata-war/etc/public-package/README.txt index 21cd555d7a..f6f1fb7611 100644 --- a/zanata-war/etc/public-package/README.txt +++ b/zanata-war/etc/public-package/README.txt @@ -1,3 +1,3 @@ This folder contains files necessary to package the publicly available Zanata download. See ../scripts/zanata-server-package.sh for details on how this is done. -The files are located as they would on the root of the JBoss server. \ No newline at end of file +All file modifications should be done as patch files. \ No newline at end of file diff --git a/zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml b/zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml deleted file mode 100644 index 2dcef2efb1..0000000000 --- a/zanata-war/etc/public-package/modules/system/layers/base/sun/jdk/main/module.xml +++ /dev/null @@ -1,97 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/zanata-war/etc/public-package/patches/as7.patch b/zanata-war/etc/public-package/patches/as7.patch new file mode 100644 index 0000000000..10342dcd39 --- /dev/null +++ b/zanata-war/etc/public-package/patches/as7.patch @@ -0,0 +1,64 @@ +diff -ru jboss-as-7.2.0.Final/modules/system/layers/base/sun/jdk/main/module.xml jboss-as-7.2.0.Final.zanata/modules/system/layers/base/sun/jdk/main/module.xml +--- jboss-as-7.2.0.Final/modules/system/layers/base/sun/jdk/main/module.xml 2013-08-07 09:00:18.000000000 +1000 ++++ jboss-as-7.2.0.Final.zanata/modules/system/layers/base/sun/jdk/main/module.xml 2013-08-23 16:25:25.551155172 +1000 +@@ -30,6 +30,7 @@ + + + ++ + + + +Only in jboss-as-7.2.0.Final.zanata/modules/system/layers/base/sun/jdk/main: module.xml~ +diff -ru jboss-as-7.2.0.Final/standalone/configuration/standalone.xml jboss-as-7.2.0.Final.zanata/standalone/configuration/standalone.xml +--- jboss-as-7.2.0.Final/standalone/configuration/standalone.xml 2013-08-07 09:00:10.000000000 +1000 ++++ jboss-as-7.2.0.Final.zanata/standalone/configuration/standalone.xml 2013-08-23 16:29:11.284878227 +1000 +@@ -25,6 +25,10 @@ + + + ++ ++ ++ ++ + + + +@@ -212,6 +216,12 @@ + + + ++ ++ ++ ++ ++ ++ + + + +@@ -222,6 +232,16 @@ + + + ++ ++ ++ ++ ++ ++ ++ ++ ++ ++ + + + +@@ -304,4 +324,4 @@ + + + +- +\ No newline at end of file ++ +Only in jboss-as-7.2.0.Final.zanata/standalone/configuration: standalone.xml~ diff --git a/zanata-war/etc/public-package/standalone/configuration/standalone.xml b/zanata-war/etc/public-package/standalone/configuration/standalone.xml deleted file mode 100644 index a48708d822..0000000000 --- a/zanata-war/etc/public-package/standalone/configuration/standalone.xml +++ /dev/null @@ -1,329 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - jdbc:h2:mem:test;DB_CLOSE_DELAY=-1 - h2 - - sa - sa - - - - - org.h2.jdbcx.JdbcDataSource - - - - - - - - - false - true - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - true - ${jboss.bind.address:127.0.0.1} - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/zanata-war/etc/scripts/zanata-server-package.sh b/zanata-war/etc/scripts/zanata-server-package.sh index 144a18f21f..797b4afd61 100755 --- a/zanata-war/etc/scripts/zanata-server-package.sh +++ b/zanata-war/etc/scripts/zanata-server-package.sh @@ -42,8 +42,8 @@ rm -rf $JBOSS_TMP_DIR/docs # Add Zanata specific files cp $ZANATA_WAR_HOME/target/zanata-*.war $JBOSS_TMP_DIR/standalone/deployments/zanata.war -cp $ZANATA_WAR_HOME/src/etc/zanata-ds.xml $JBOSS_TMP_DIR//standalone/deployments -cp -r $ZANATA_WAR_HOME/etc/public-package/* $JBOSS_TMP_DIR/ +cp $ZANATA_WAR_HOME/src/etc/zanata-ds.xml $JBOSS_TMP_DIR/standalone/deployments +patch -p1 --verbose -d $JBOSS_TMP_DIR/ < $ZANATA_WAR_HOME/etc/public-package/patches/as7.patch # Get Maven dependencies mvn dependency:get -DrepoUrl=http://repo1.maven.org -Dartifact=mysql:mysql-connector-java:$MYSQL_DRV_VERSION From e9037ce03c833ae44c8c44e63364588c62363d7a Mon Sep 17 00:00:00 2001 From: "Carlos A. Munoz" Date: Wed, 11 Sep 2013 10:10:16 +1000 Subject: [PATCH 3/4] Add the zanata.war location as a second argument to the script. Also modify the as7.patch file to now make as7 accessible from outside localhost. --- .../etc/public-package/patches/as7.patch | 21 ++++++++++++++++++- .../etc/scripts/zanata-server-package.sh | 7 ++++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/zanata-war/etc/public-package/patches/as7.patch b/zanata-war/etc/public-package/patches/as7.patch index 10342dcd39..b6874b6307 100644 --- a/zanata-war/etc/public-package/patches/as7.patch +++ b/zanata-war/etc/public-package/patches/as7.patch @@ -12,7 +12,7 @@ diff -ru jboss-as-7.2.0.Final/modules/system/layers/base/sun/jdk/main/module.xml Only in jboss-as-7.2.0.Final.zanata/modules/system/layers/base/sun/jdk/main: module.xml~ diff -ru jboss-as-7.2.0.Final/standalone/configuration/standalone.xml jboss-as-7.2.0.Final.zanata/standalone/configuration/standalone.xml --- jboss-as-7.2.0.Final/standalone/configuration/standalone.xml 2013-08-07 09:00:10.000000000 +1000 -+++ jboss-as-7.2.0.Final.zanata/standalone/configuration/standalone.xml 2013-08-23 16:29:11.284878227 +1000 ++++ jboss-as-7.2.0.Final.zanata/standalone/configuration/standalone.xml 2013-09-11 09:47:17.613643411 +1000 @@ -25,6 +25,10 @@ @@ -54,6 +54,24 @@ diff -ru jboss-as-7.2.0.Final/standalone/configuration/standalone.xml jboss-as-7 +@@ -279,7 +299,7 @@ + + + +- ++ + + + +@@ -287,7 +307,7 @@ + ~ Used for IIOP sockets in the standard configuration. + ~ To secure JacORB you need to setup SSL + --> +- ++ + + + @@ -304,4 +324,4 @@ @@ -62,3 +80,4 @@ diff -ru jboss-as-7.2.0.Final/standalone/configuration/standalone.xml jboss-as-7 \ No newline at end of file + Only in jboss-as-7.2.0.Final.zanata/standalone/configuration: standalone.xml~ +Only in jboss-as-7.2.0.Final.zanata: zanata-as7.patch diff --git a/zanata-war/etc/scripts/zanata-server-package.sh b/zanata-war/etc/scripts/zanata-server-package.sh index 797b4afd61..b63ea9112e 100755 --- a/zanata-war/etc/scripts/zanata-server-package.sh +++ b/zanata-war/etc/scripts/zanata-server-package.sh @@ -8,6 +8,7 @@ # # Parameters: # 1. JBoss 7 zip distribution location. +# 2. Zanata war location. # # Pre-requisites: # 1. Apache maven in the path @@ -19,6 +20,10 @@ MYSQL_DRV_VERSION=5.1.18 JBOSS_ZIP_LOC=$1 JBOSS_ZIP_PARENT=${JBOSS_ZIP_LOC%/*} +# Get the Zanata war location from parameters +ZANATA_WAR=$2 + + # Zanata War project Dir ZANATA_WAR_HOME=../.. @@ -41,7 +46,7 @@ rm -rf $JBOSS_TMP_DIR/bin/client rm -rf $JBOSS_TMP_DIR/docs # Add Zanata specific files -cp $ZANATA_WAR_HOME/target/zanata-*.war $JBOSS_TMP_DIR/standalone/deployments/zanata.war +cp $ZANATA_WAR $JBOSS_TMP_DIR/standalone/deployments/zanata.war cp $ZANATA_WAR_HOME/src/etc/zanata-ds.xml $JBOSS_TMP_DIR/standalone/deployments patch -p1 --verbose -d $JBOSS_TMP_DIR/ < $ZANATA_WAR_HOME/etc/public-package/patches/as7.patch From 7e0a0751678d48913914ac1adf2383f9eb4b9929 Mon Sep 17 00:00:00 2001 From: "Carlos A. Munoz" Date: Wed, 11 Sep 2013 10:40:42 +1000 Subject: [PATCH 4/4] Add help message when zanata-server-package is not invoked correctly. --- zanata-war/etc/scripts/zanata-server-package.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/zanata-war/etc/scripts/zanata-server-package.sh b/zanata-war/etc/scripts/zanata-server-package.sh index b63ea9112e..9237b48fb1 100755 --- a/zanata-war/etc/scripts/zanata-server-package.sh +++ b/zanata-war/etc/scripts/zanata-server-package.sh @@ -13,6 +13,14 @@ # Pre-requisites: # 1. Apache maven in the path +if [ $# -lt 2 ]; then + echo "Usage:" + echo "zanata-server-package.sh JBOSS_LOCATION ZANATA_WAR_LOCATION" + echo "" + echo "This must be done with a jboss AS 7.2.0 zip file with Hibernate 4.2.0.Final" + exit 1 +fi + # Mysql Driver version to be used MYSQL_DRV_VERSION=5.1.18