From 0045c5de89c9c964437db1bd7164df0af766cd4a Mon Sep 17 00:00:00 2001 From: David Mason Date: Tue, 30 Jun 2015 13:33:09 +1000 Subject: [PATCH 1/5] Add explicit dependency on jms. This was causing a deployment failure on JBoss EAP 6.3.3 with a root cause of java.lang.ClassNotFoundException: javax.jms.MessageListener from [Module "deployment.zanata.war:main" from Service Module Loader] Related: https://issues.jboss.org/browse/WFLY-4642 --- .../src/main/webapp-jboss/WEB-INF/jboss-deployment-structure.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/zanata-war/src/main/webapp-jboss/WEB-INF/jboss-deployment-structure.xml b/zanata-war/src/main/webapp-jboss/WEB-INF/jboss-deployment-structure.xml index 2d2547b92f..ceb0ed0db1 100644 --- a/zanata-war/src/main/webapp-jboss/WEB-INF/jboss-deployment-structure.xml +++ b/zanata-war/src/main/webapp-jboss/WEB-INF/jboss-deployment-structure.xml @@ -25,6 +25,7 @@ + From b5775c51d5c5071beacc01331b0f0c2081d25d9d Mon Sep 17 00:00:00 2001 From: David Mason Date: Tue, 30 Jun 2015 15:44:11 +1000 Subject: [PATCH 2/5] refactor(jsf): move project translation settings to separate files To reduce project settings template to a more maintainable size. --- .../project/settings-tab-translation.xhtml | 58 ++++++++ .../WEB-INF/layout/project/settings-tab.xhtml | 119 +---------------- .../project/validation-settings-block.xhtml | 124 ++++++++++++++++++ 3 files changed, 183 insertions(+), 118 deletions(-) create mode 100644 zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-translation.xhtml create mode 100644 zanata-war/src/main/webapp/WEB-INF/layout/project/validation-settings-block.xhtml diff --git a/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-translation.xhtml b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-translation.xhtml new file mode 100644 index 0000000000..efd7e97795 --- /dev/null +++ b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-translation.xhtml @@ -0,0 +1,58 @@ + + + + + + + + +

+ #{msgs['jsf.Translation']} +

+ + + +

#{msgs['jsf.Validation']}

+

#{msgs['jsf.Validation.messages']}

+ + +
+ +

#{msgs['jsf.CopyTrans']}

+ +

#{msgs['jsf.Copytrans.message']} + + + +

+ +

#{msgs['jsf.Copytrans.message2']}

+ +
+ +
diff --git a/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml index abbb40a266..f6578f43e6 100644 --- a/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml +++ b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml @@ -9,11 +9,6 @@ @@ -48,19 +42,6 @@ - - - - - - - - - - @@ -240,105 +221,7 @@
  • -

    - #{msgs['jsf.Translation']} -

    - - -

    #{msgs['jsf.Validation']}

    - -

    #{msgs['jsf.Validation.messages']}

    - - -
      - -
    • -
      -
      - - -

      - #{validationAction.description} - - - #{msgs['jsf.tooltip.More']} - … - -

      -
      -
      -
      - - - - - - - - - -
      -
      -
      - -
    • -
      -
    -
    -
    -

    #{msgs['jsf.CopyTrans']}

    - -

    #{msgs['jsf.Copytrans.message']} - - - -

    - -

    #{msgs['jsf.Copytrans.message2']}

    - -
    +
  • diff --git a/zanata-war/src/main/webapp/WEB-INF/layout/project/validation-settings-block.xhtml b/zanata-war/src/main/webapp/WEB-INF/layout/project/validation-settings-block.xhtml new file mode 100644 index 0000000000..15647a392a --- /dev/null +++ b/zanata-war/src/main/webapp/WEB-INF/layout/project/validation-settings-block.xhtml @@ -0,0 +1,124 @@ + + + + + + + + + + + +
      + +
    • +
      +
      + + +

      + #{validationAction.description} + + + #{msgs['jsf.tooltip.More']} + … + +

      +
      +
      +
      + + + + + + + + + +
      +
      +
      + +
    • +
      +
    +
    + +
    From e0d4415b9c486eddd7e2cd3ab5703088fd3db6fe Mon Sep 17 00:00:00 2001 From: David Mason Date: Wed, 1 Jul 2015 11:21:30 +1000 Subject: [PATCH 3/5] refactor(jsf): move project general settings to separate file To reduce project settings template to a more maintainable size. --- .../layout/project/settings-tab-general.xhtml | 130 ++++++++++++++++++ .../WEB-INF/layout/project/settings-tab.xhtml | 105 +------------- 2 files changed, 131 insertions(+), 104 deletions(-) create mode 100644 zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-general.xhtml diff --git a/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-general.xhtml b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-general.xhtml new file mode 100644 index 0000000000..db29137b2d --- /dev/null +++ b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab-general.xhtml @@ -0,0 +1,130 @@ + + + +

    #{msgs['jsf.General']}

    + + + + +

    #{msgs['jsf.project.SourceCode']}

    + +
    +
    +
    + #{msgs['jsf.project.HomePage']} + #{msgs['jsf.field.optional']} + + + + + + + + +

    + +

    +
    +
    +
    +
    + #{msgs['jsf.field.repository']} + #{msgs['jsf.field.optional']} + + + + + + + +

    + +

    +
    +
    +
    + +
    + +
    + +
    + + + + + #{msgs['jsf.project.readonly']} + + +

    #{msgs['jsf.project.readonly.Message']}

    +
    + + + + + + #{msgs['jsf.project.writable']} + + +

    #{msgs['jsf.project.writable.Message']}

    +
    + + + + + #{msgs['jsf.DeleteThisProject']} + + +

    #{msgs['jsf.DeleteProject.Message']}

    +
    +
    +
    +
    + +
    diff --git a/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml index f6578f43e6..5831287b73 100644 --- a/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml +++ b/zanata-war/src/main/webapp/WEB-INF/layout/project/settings-tab.xhtml @@ -4,7 +4,6 @@ xmlns:a4j="http://richfaces.org/a4j" xmlns:rich="http://richfaces.org/rich" xmlns:s="http://jboss.org/schema/seam/taglib" - xmlns:f="http://java.sun.com/jsf/core" xmlns:zanata="http://java.sun.com/jsf/composite/zanata">