From 9620e5e7f9d92fe90152f99e26eafc3a62fe0f88 Mon Sep 17 00:00:00 2001
From: David Mason <dr.d.mason@gmail.com>
Date: Fri, 2 Aug 2013 16:12:45 +1000
Subject: [PATCH] rhbz990373 disable source upload buttons when no file
 specified

    A null pointer exception occurred when an upload was submitted
    without first selecting a file. This prevents submission whenever
    a file is not selected.
---
 .../main/webapp/iteration/source_files.xhtml  | 32 ++++++++++++++++---
 .../src/main/webapp/resources/css/zanata.css  |  5 +++
 2 files changed, 33 insertions(+), 4 deletions(-)

diff --git a/zanata-war/src/main/webapp/iteration/source_files.xhtml b/zanata-war/src/main/webapp/iteration/source_files.xhtml
index 265222e3d8..121aabdabb 100644
--- a/zanata-war/src/main/webapp/iteration/source_files.xhtml
+++ b/zanata-war/src/main/webapp/iteration/source_files.xhtml
@@ -15,6 +15,7 @@
         <script type="text/javascript">
             function openUploadDocPanel() {
                 #{rich:component('uploadDocPanel')}.show();
+                checkIfGeneralFileSelected()
                 return false;
             }
 
@@ -22,6 +23,7 @@
                 #{rich:element('uploadPanelHeader')}.innerHTML = '#{messages['jsf.iteration.files.UploadDocument']}: ' + docId;
                 #{rich:element('uploadDocId')}.value = docId;
                 #{rich:component('uploadPanel')}.show();
+                checkIfSpecificFileSelected();
             }
 
             function hideUploadPanel() {
@@ -37,6 +39,22 @@
             function focusNameFilterInput() {
                 #{rich:element('name_filter_input')}.focus();
             }
+
+            function checkIfFileSelected(fileInput, submitButton) {
+                var noFileSelected = fileInput.value === undefined || fileInput.value === "";
+                submitButton.disabled = noFileSelected;
+            }
+
+            function checkIfSpecificFileSelected() {
+                checkIfFileSelected(#{rich:element('specificDocFileInput')},
+                                    #{rich:element('specificDocSubmitUploadButton')});
+            }
+
+            function checkIfGeneralFileSelected() {
+                checkIfFileSelected(#{rich:element('generalDocFileUpload')},
+                                    #{rich:element('generalDocSubmitUploadButton')});
+            }
+
         </script>
     </ui:define>
 
@@ -228,7 +246,9 @@
                 <h:outputText id="uploadPanelHeader"/>
             </f:facet>
             <h:form id="uploadForm" enctype="multipart/form-data">
-                <s:fileUpload accept="*"
+                <s:fileUpload id="specificDocFileInput"
+                              accept="*"
+                              onchange="checkIfSpecificFileSelected();"
                               data="#{projectIterationFilesAction.documentFileUpload.fileContents}"
                               fileName="#{projectIterationFilesAction.documentFileUpload.fileName}"/>
                 <h:inputHidden id="uploadDocId" value="#{projectIterationFilesAction.documentFileUpload.docId}"/>
@@ -256,7 +276,8 @@
                     </a>
                 </rich:collapsiblePanel>
                 <div align="right">
-                    <h:commandButton value="#{messages['jsf.Upload']}"
+                    <h:commandButton id="specificDocSubmitUploadButton"
+                                     value="#{messages['jsf.Upload']}"
                                      action="#{projectIterationFilesAction.uploadDocumentFile}"/>
                     <h:commandButton value="#{messages['jsf.Cancel']}"
                                      onclick="return hideUploadPanel();"/>
@@ -274,7 +295,9 @@
                 <h:outputText value="#{messages['jsf.iteration.files.UploadDocument']}"/>
             </f:facet>
             <h:form id="uploadDocForm" enctype="multipart/form-data">
-                <s:fileUpload accept="*"
+                <s:fileUpload id="generalDocFileUpload"
+                              accept="*"
+                              onchange="checkIfGeneralFileSelected();"
                               data="#{projectIterationFilesAction.documentFileUpload.fileContents}"
                               fileName="#{projectIterationFilesAction.documentFileUpload.fileName}"/>
                 <br/>
@@ -306,7 +329,8 @@
                     </a>
                 </rich:collapsiblePanel>
                 <div align="right">
-                    <h:commandButton value="#{messages['jsf.Upload']}"
+                    <h:commandButton id="generalDocSubmitUploadButton"
+                                     value="#{messages['jsf.Upload']}"
                                      action="#{projectIterationFilesAction.uploadDocumentFile}"/>
                     <h:commandButton value="#{messages['jsf.Cancel']}"
                                      onclick="return hideDocUploadPanel();"/>
diff --git a/zanata-war/src/main/webapp/resources/css/zanata.css b/zanata-war/src/main/webapp/resources/css/zanata.css
index 8d9f107798..df736117e8 100644
--- a/zanata-war/src/main/webapp/resources/css/zanata.css
+++ b/zanata-war/src/main/webapp/resources/css/zanata.css
@@ -130,6 +130,11 @@ input[readonly] {
     color:#545454;
 }
 
+input[disabled] {
+    opacity: 0.5;
+    cursor: default;
+}
+
 button:hover,input[type="reset"]:hover,input[type="submit"]:hover,input[type="button"]:hover 
 {
 	background: #CCC;