diff --git a/zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java b/zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java index 377ddd3dc4..3343829d3d 100644 --- a/zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java +++ b/zanata-model/src/main/java/org/zanata/model/HTextFlowTargetReviewComment.java @@ -118,25 +118,4 @@ public Integer getTargetVersion() return targetVersion; } - // TODO pahuang we probably want to cache below two methods - @Transient - public ContentState getContentStateOfCommentedTarget() - { - if (textFlowTarget.getVersionNum().equals(targetVersion)) - { - return textFlowTarget.getState(); - } - return textFlowTarget.getHistory().get(targetVersion).getState(); - } - - @Transient - public List getContentsOfCommentedTarget() - { - if (textFlowTarget.getVersionNum().equals(targetVersion)) - { - return textFlowTarget.getContents(); - } - return textFlowTarget.getHistory().get(targetVersion).getContents(); - } - } diff --git a/zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java b/zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java index ea67fe2f17..2771b62fd4 100644 --- a/zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java +++ b/zanata-war/src/test/java/org/zanata/dao/TextFlowTargetReviewCommentsDAOJPATest.java @@ -88,7 +88,6 @@ public void testTargetUserComment() List result = reviewCommentsDAO.getReviewComments(new TransUnitId(target.getTextFlow().getId()), target.getLocaleId()); assertThat(result, Matchers.hasSize(1)); - assertThat(result.get(0).getContentsOfCommentedTarget(), Matchers.equalTo(target.getContents())); assertThat(result.get(0).getCommenterName(), Matchers.equalTo(person.getName())); assertThat(result.get(0).getCreationDate(), Matchers.lessThanOrEqualTo(new Date())); } @@ -113,7 +112,6 @@ public void testTargetUserCommentMadeOnPreviousTranslation() List result = reviewCommentsDAO.getReviewComments(new TransUnitId(target.getTextFlow().getId()), target.getLocaleId()); - assertThat(result.get(0).getContentsOfCommentedTarget(), Matchers.equalTo(oldTranslation)); assertThat(result.get(0).getTargetVersion(), Matchers.equalTo(oldVersion)); } }