From d7ea646764248e2bacdf689324292fea9a14f909 Mon Sep 17 00:00:00 2001 From: David Mason Date: Mon, 17 Aug 2015 16:13:18 +1000 Subject: [PATCH] do not show people as project members when they have no roles People were being temporarily shown in the project list with no roles when they should have been completely removed. It was just a caching issue with the people sorting object. --- .../main/java/org/zanata/action/ProjectHomeAction.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/zanata-war/src/main/java/org/zanata/action/ProjectHomeAction.java b/zanata-war/src/main/java/org/zanata/action/ProjectHomeAction.java index 3cc2e60ac9..6b20ee6d6e 100644 --- a/zanata-war/src/main/java/org/zanata/action/ProjectHomeAction.java +++ b/zanata-war/src/main/java/org/zanata/action/ProjectHomeAction.java @@ -791,6 +791,11 @@ public void savePermissionDialogSelections() { personRoles = null; personLocaleRoles = null; project = null; + + // Person may have no roles left and no longer belong in the list, so + // ensure the list of people is refreshed. + peopleFilterComparator.clearAllMembers(); + peopleFilterComparator.sortPeopleList(); } @@ -838,6 +843,10 @@ protected List fetchAll() { return allMembers; } + public void clearAllMembers() { + allMembers = null; + } + @Override protected boolean include(HPerson person, final String filter) { if(StringUtils.isBlank(filter)) {