From ef9cdda316d5d8fcc5fef1af4986e11276ce3f1a Mon Sep 17 00:00:00 2001 From: Patrick Huang Date: Fri, 16 Aug 2013 09:49:37 +1000 Subject: [PATCH] rhbz996388 - move some work after validation is done --- .../webtrans/server/rpc/AddReviewCommentHandler.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java b/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java index d3b1c0e9b9..ccdee3da5f 100644 --- a/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java +++ b/zanata-war/src/main/java/org/zanata/webtrans/server/rpc/AddReviewCommentHandler.java @@ -89,14 +89,15 @@ public AddReviewCommentResult execute(AddReviewCommentAction action, ExecutionCo WorkspaceId workspaceId = action.getWorkspaceId(); securityServiceImpl.checkWorkspaceStatus(workspaceId); - HLocale hLocale = localeServiceImpl.getByLocaleId(workspaceId.getLocaleId()); - TranslationWorkspace workspace = translationWorkspaceManager.getOrRegisterWorkspace(workspaceId); - HTextFlowTarget hTextFlowTarget = textFlowTargetDAO.getTextFlowTarget(action.getTransUnitId().getValue(), workspaceId.getLocaleId()); if (hTextFlowTarget == null || hTextFlowTarget.getState().isUntranslated()) { throw new ActionException("comment on untranslated message is pointless!"); } + + HLocale hLocale = localeServiceImpl.getByLocaleId(workspaceId.getLocaleId()); + TranslationWorkspace workspace = translationWorkspaceManager.getOrRegisterWorkspace(workspaceId); + HTextFlowTargetReviewComment hComment = hTextFlowTarget.addReviewComment(action.getContent(), authenticatedAccount.getPerson()); textFlowTargetDAO.makePersistent(hTextFlowTarget); textFlowTargetDAO.flush();