Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

WildFly fixes, test configuration and dynamic ports #567

Closed
wants to merge 26 commits into from
Closed

WildFly fixes, test configuration and dynamic ports #567

wants to merge 26 commits into from

Conversation

seanf
Copy link
Contributor

@seanf seanf commented Aug 29, 2014

No description provided.

@carlosmunoz
Copy link
Member

@seanf Since this includes the logging out issue, did you see that happen again?

@carlosmunoz
Copy link
Member

👍 Reviewed

@seanf
Copy link
Contributor Author

seanf commented Aug 29, 2014

I don't tend to bother logging out of Zanata explicitly, so I haven't been
running into it, but I wanted to build on top of your fix.

On 29 August 2014 15:24, Carlos Munoz notifications@github.com wrote:

@seanf https://github.com/seanf Since this includes the logging out
issue, did you see that happen again?

—
Reply to this email directly or view it on GitHub
#567 (comment).

@seanf seanf mentioned this pull request Aug 29, 2014
Closed
@definite definite added the ON_QA label Sep 1, 2014
@seanf seanf assigned definite and unassigned carlosmunoz Sep 1, 2014
@definite
Copy link
Member

definite commented Sep 2, 2014

When running using non-root, it may occationally showing error message "An unexpected error has occured. Please report ....)

And the server log revealed:
Caused by: java.io.FileNotFoundException: velocity.log (Permission denied)

@definite definite removed the ON_QA label Sep 2, 2014
@seanf
Copy link
Contributor Author

seanf commented Sep 2, 2014

Upon what sort of occasions? Could you please email me the log file?

On 2014-09-02 11:47, Ding-Yi Chen wrote:

When running using non-root, it may occationally showing error message
"An unexpected error has occured. Pleas report ..)

And the server log revealed:
Caused by: java.io.FileNotFoundException: velocity.log (Permission denied)

—
Reply to this email directly or view it on GitHub
#567 (comment).

Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat

@definite
Copy link
Member

definite commented Sep 2, 2014

I was doing manage user actions, like enable user and set roles.
It actually somewhat random.

@seanf
Copy link
Contributor Author

seanf commented Sep 4, 2014

The velocity log should be taken care of by #575

Some other errors may have been caused by running against mariadb 5.6. See https://bugzilla.redhat.com/show_bug.cgi?id=1048293 #581 will add checks for this.

@seanf seanf mentioned this pull request Sep 5, 2014
Closed
@seanf seanf mentioned this pull request Sep 5, 2014
Closed
@definite
Copy link
Member

definite commented Sep 8, 2014

I cannot push gcc source files with maven client.

@definite
Copy link
Member

definite commented Sep 9, 2014

Steps to reproduce logout:

  1. Log in
  2. Go to any project
  3. Logout

Actual:
Error message "We are sorry .."

Also in project version page:

  1. Log in
  2. Go to any project
  3. Go to any version
  4. log out

Actual:
Page reloaded, and your are still logined.

@definite
Copy link
Member

definite commented Sep 9, 2014

  • Can logout from project page
  • Can logout from group page
  • Can logout from project-version page.

@seanf seanf force-pushed the fix-login-redirect-loop branch 7 times, most recently from 54fed1c to 2ca5485 Compare September 17, 2014 07:08
Carlos A. Munoz and others added 3 commits September 17, 2014 17:52
@seanf
Fix issue when logging out in wildfly.
a80270f 
An unnecessary logout.xhtml page was being used to be able to capture the request, perform the logout and redirect to the home page again. This is not necesary and might be causing an intermitent problem in wildfly.
@seanf
Put GWT dependencies last to ensure they don't override Java APIs
1e3e889
@seanf
Add workarounds for WildFly bugs: WFLY-3617, WFLY-3744
ff71c09
@seanf seanf changed the title WildFly workarounds for servlet context path and cookie path WildFly fixes and test configuration Sep 19, 2014
@seanf seanf changed the title WildFly fixes and test configuration WildFly fixes, test configuration and dynamic ports Sep 19, 2014
@carlosmunoz
Copy link
Member

👍 Latest code changes look good. Maven changes are a bit hard to read, but nothing in there raises any red flags.

@seanf seanf added Ungood and removed Ungood labels Sep 19, 2014
@seanf
Copy link
Contributor Author

seanf commented Sep 19, 2014

Warning: the logout problems reported by @definite are happening on EAP 6.2 as well, even though all the functional tests are passing.

I'm getting 400 bad request in the Chrome console.

@carlosmunoz
Copy link
Member

@definite Fixed the logout issue.

@seanf seanf removed the Ungood label Sep 19, 2014
@carlosmunoz
Copy link
Member

@zanata-jenkins retest this please

carlosmunoz pushed a commit that referenced this pull request Sep 23, 2014
WildFly fixes, test configuration and dynamic ports
e81b912 
Merge pull request: #567
Squashed commit of the following:

commit aae9a34
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Fri Sep 19 16:05:10 2014 +1000

    Switch embedded wildfly to managed

commit b688b87
Author: Carlos A. Munoz <camunoz@redhat.com>
Date:   Fri Sep 19 13:54:56 2014 +1000

    Correct issue when logging out from certain pages.

commit 991bd93
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Fri Sep 19 12:48:44 2014 +1000

    Activate profiles with -Dappserver=(jbosseap6|wildfly8)

commit 86f1565
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 18 21:04:11 2014 +1000

    Change allocate-jboss-ports to work in Jenkins

commit 97a2b04
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 18 16:33:15 2014 +1000

    Fix port

commit 9da422a
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 18 15:20:57 2014 +1000

    Remove use of tmp war (cont.)

commit 8347357
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 18 15:11:39 2014 +1000

    Correct management port for wildfly

commit 6d93043
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 18 13:40:40 2014 +1000

    Remove misplaced Maven property expression

commit 47957cb
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Wed Sep 17 20:48:04 2014 +1000

    Clean up pom for static analysers

    - Update shrinkwrap and transitive test dependencies to satisfy
      RequireUpperBoundDeps
    - Exclude org.jboss.remoting3 (duplicates org.jboss.remoting classes)

commit ddb30e4
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Wed Sep 17 18:18:36 2014 +1000

    Allocate ports separately

commit 5a2dca8
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Tue Sep 16 14:11:44 2014 +1000

    Split arquillian config into two profiles: jbosseap6 & wildfly81

commit 82ead14
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Tue Sep 16 10:17:56 2014 +1000

    Remove use of tmp war

commit 949b2bb
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Tue Sep 16 10:48:53 2014 +1000

    Fix profile activation on Maven 3.2.2+ (MNG-4565)

commit 21cae28
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Mon Sep 15 21:02:45 2014 +1000

    Control WildFly ports via environment variables

commit 358c87a
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Mon Sep 15 16:16:22 2014 +1000

    Rewrite allocate-ports in Python for faster startup

commit 1f4c222
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Mon Sep 15 15:59:31 2014 +1000

    Generate unused port numbers for JBoss using Groovy script

commit 529d8eb
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Fri Sep 12 15:39:42 2014 +1000

    Make ports configurable via system properties and env vars

    Also set port-offset=0 and adjust port numbers manually (by adding 100)

commit cacfcef
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Tue Sep 9 16:35:34 2014 +1000

    Log permission check failure as WARN, success as DEBUG

commit 68823a3
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Tue Sep 9 13:29:54 2014 +1000

    Adjust programmatic log config in ZanataInit

commit b7d45cb
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Tue Sep 9 10:23:01 2014 +1000

    Delete HTextFlowHistory before HTextFlow

commit 5419e0f
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 4 13:11:48 2014 +1000

    Enhance connection wrapping: logging, configuration, mariadb

    - Log information about database and driver.
    - Check for supported database/version.
    - Add system property 'zanata.connection.use.wrapper' for explicit
      control.
    - Disable connection wrapping for mariadb as well as mysql.
    - Log what WrapperManager does.

commit 1d6a942
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Thu Sep 4 12:56:38 2014 +1000

    Enable connection debugging

commit 4fafeee
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Wed Sep 3 10:53:48 2014 +1000

    Send Velocity log to SLF4J (via Commons Logging)

commit ff71c09
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Fri Aug 29 15:16:28 2014 +1000

    Add workarounds for WildFly bugs: WFLY-3617, WFLY-3744

commit 1e3e889
Author: Sean Flanigan <sflaniga@redhat.com>
Date:   Fri Aug 29 15:13:57 2014 +1000

    Put GWT dependencies last to ensure they don't override Java APIs

commit a80270f
Author: Carlos A. Munoz <camunoz@redhat.com>
Date:   Thu Aug 28 09:03:48 2014 +1000

    Fix issue when logging out in wildfly.

    An unnecessary logout.xhtml page was being used to be able to capture the request, perform the logout and redirect to the home page again. This is not necesary and might be causing an intermitent problem in wildfly.
@carlosmunoz
Copy link
Member

Merged in commit: e81b912

@carlosmunoz carlosmunoz deleted the fix-login-redirect-loop branch September 23, 2014 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@definite definite

Labels
Verified
Projects
None yet
Milestone
No milestone
3 participants
@seanf @carlosmunoz @definite