Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Rhbz1082840 delete project or version #808

Merged
merged 8 commits into from May 29, 2015

Conversation

huangp
Copy link
Collaborator

@huangp huangp commented May 14, 2015

@djansen-redhat
Copy link
Contributor

  • Archive functional tests are broken
  • The project is still searchable, causing a javax.persistence.EntityNotFoundException when selected
  • The Delete and Cancel buttons are too close together
  • If the user deletes a version from the project, then creates a new version, the create page still thinks there is a pre-existing version and will offer the "From Previous" option. Selecting this will present an invalid page with both the box checked and the types list shown.
    Creating will now cause a permanently read-only version.
    Error in log is "Cannot find project iteration of 004-alias:" (where 004-alias was the project name)
  • I believe this somehow breaks administrator's ability to view Archived groups.
  • The Activity lists still allow access to the deleted projects - can we do something about this?

"Record not found But you can help us fix it!"
Invalid Workspace. Project is obsolete. Try opening the workspace from the link on the project page.

  • Copy to New Version doesn't work any more

Caused by: javax.faces.el.EvaluationException: javax.validation.ConstraintViolationException: Validation failed for classes [org.zanata.model.HProjectIteration] during persist time for groups [javax.validation.groups.Default, ]
[INFO] [talledLocalContainer] List of constraint violations:[
[INFO] [talledLocalContainer] ConstraintViolationImpl{interpolatedMessage='may not be null', propertyPath=slug, rootBeanClass=class org.zanata.model.HProjectIteration, messageTemplate='{javax.validation.constraints.NotNull.message}'}
[INFO] [talledLocalContainer] ]

@@ -126,6 +126,7 @@ public ProjectsPage setReadOnlyFilterEnabled(final boolean enabled) {
return new ProjectsPage(getDriver());
}

@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just delete this method? or update the test?

@alex-sl-eng
Copy link
Member

Notes: The updates of Objects.toStringHelper to MoreObjects.toStringHelper is already done in #818.

@alex-sl-eng alex-sl-eng self-assigned this May 20, 2015
@huangp
Copy link
Collaborator Author

huangp commented May 20, 2015

I will revert my last commit (change Objects to MoreObjects)

@huangp
Copy link
Collaborator Author

huangp commented May 21, 2015

Done

@alex-sl-eng
Copy link
Member

👍

@huangp
Copy link
Collaborator Author

huangp commented May 21, 2015

the build depends on zanata/zanata-client#65

@huangp
Copy link
Collaborator Author

huangp commented May 26, 2015

Added: user has to type in the name again to confirm delete.

…at we can select them using css selector in tests
huangp pushed a commit that referenced this pull request May 29, 2015
Rhbz1082840 delete project or version
@huangp huangp merged commit 8ac9d99 into integration/master May 29, 2015
@huangp huangp deleted the rhbz1082840-del-proj-ver branch May 29, 2015 03:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants