This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
New permission for create project #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +88,7 @@ public static boolean canManageRoles(String target) { | |||
| /* Any authenticated user can create a project */ | |||
There was a problem hiding this comment.
Update comment to match the new behaviour.
|
👍 |
| "Could not create 'project-creator' role"); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we are at (or past) the point where this bit of logic should be extracted into a method, called once for each role we want. (Or a for loop.)
|
✅ Tested |
|
Merged into integration/master. 7e90a9b |
|
Shouldn't the squash merge 7e90a9b have a name like "feat(role): New permission for create project" instead of "feat: role: New permission for create project"? |
|
@seanf you're right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1214502