New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinterpret_cast<uint64_t*> causes a crash on some 32bit platforms (Android) #223

Closed
jonberling opened this Issue May 6, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@jonberling

jonberling commented May 6, 2013

Using a reinterpret_cast<uint64_t*> can cause a crash on some 32 bit ARM platforms due to alignment issues. However, these statements can be replaced with a memcpy, which will work fine.

@zaphoyd

This comment has been minimized.

Owner

zaphoyd commented May 6, 2013

Is there a specific place you see reinterpret_cast<uint64_t*> used? I know I cast to size_t* occasionally, but I can't find any casts to uint64_t.

@jonberling

This comment has been minimized.

jonberling commented May 6, 2013

I'm using the latest 0.2.x release.

processors/hybi_headers.cpp, around line 150 and 270
websocket_frame.hpp, around line 400, and 500

zaphoyd added a commit that referenced this issue Jun 8, 2013

@zaphoyd

This comment has been minimized.

Owner

zaphoyd commented Jun 8, 2013

In theory this should be fixed now on the 0.2.x branch (not master). If anyone is able to confirm on ARM 32bit hardware that would be great.

@zaphoyd

This comment has been minimized.

Owner

zaphoyd commented Feb 18, 2014

Closing this as there have been no reports of issues since it was fixed.

@zaphoyd zaphoyd closed this Feb 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment