New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case-sensitive HTTP get_header causes client to reject server handshakes for some implementations of websockets #275

Closed
CodeShark opened this Issue Jul 11, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@CodeShark

CodeShark commented Jul 11, 2013

I know RFC 6455 officially requires the server to respond to the client handshake with the headers "Upgrade", "Connection", and "Sec-WebSocket-Accept" but some server implementations I've come across use all lowercase for header keys. The most popular ws client implementations I've tested are not as strict.

@zaphoyd

This comment has been minimized.

Owner

zaphoyd commented Jul 11, 2013

This is a known issue, see #220. If it is actually causing interop issues I'll bump up the schedule for fixing it.

@zaphoyd

This comment has been minimized.

Owner

zaphoyd commented Jul 13, 2013

WebSocket++ now uses case insensitive comparisons for header operations. It does this in a way that preserves the case of any headers you set to help work around HTTP and WebSocket implementations that require specific cases. All headers generated by the library itself use the standard HTTP Title Case.

@CodeShark

This comment has been minimized.

CodeShark commented Jul 14, 2013

Awesome - thanks for the quick turnaround.

@zaphoyd zaphoyd closed this Jul 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment