New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for detecting client side hash change #5

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
2 participants
@neilff
Contributor

neilff commented Nov 3, 2017

Fixes an issue where if the same locations were passed, e.g. isOnlyHrefHashChange ('http://localhost:8000/app/explore', 'http://localhost:8000/app/explore'); it would be interpreted as a hash change in the History component.

This modifies that behaviour so that the above case would prevent the default event from occuring.

@neilff neilff requested a review from jdeal Nov 3, 2017

@neilff

This comment has been minimized.

Show comment
Hide comment
@neilff

neilff Nov 3, 2017

Contributor

@jdeal Can you take a look at these changes?

Contributor

neilff commented Nov 3, 2017

@jdeal Can you take a look at these changes?

@jdeal

jdeal approved these changes Nov 3, 2017

Looks good @neilff. Thanks for the tests!

@neilff neilff merged commit f158679 into master Nov 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@neilff neilff deleted the fix-href-hash-change branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment