Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

zapier convert: Use Prettier to format generated code #202

Merged
merged 2 commits into from
Dec 13, 2017

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Dec 11, 2017

We use these templates to generate code for converted apps. The generated code is not pretty and it's not easy to manually format code in the templates. This PR adds Prettier into the conversion process so all the rendered .json and .js files are prettified with JSON.stringify and Prettier respectively before they get written to the filesystem.

@eliangcs eliangcs changed the title [WIP] zapier convert: Use Prettier to format generated code zapier convert: Use Prettier to format generated code Dec 12, 2017
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! I really enjoy prettier. I'd even go a step further and use it and a pre-commit hook on all the code in this and core. I know the front end team uses it. I disagree with their config a bit, but like the tool a lot.

@eliangcs eliangcs merged commit bc6b5d8 into master Dec 13, 2017
@eliangcs eliangcs deleted the convert-prettier branch December 13, 2017 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants