Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

Update schema version in package-lock.json before publishing #128

Merged
merged 1 commit into from Nov 13, 2018

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Nov 12, 2018

Fixes a small annoyance where Travis fails on Node 10.x, like this build. This is because Travis runs npm ci (instead of npm install), which uses package-lock.json (instead of package.json), to install dependencies. And the script we use to bump schema version only updates package.json, leaving package-lock.json intact. To fix it, we only need to run npm install after we bump the schema version in package.json.

@eliangcs eliangcs changed the title Update schema in package lock Update schema in package-lock.json Nov 12, 2018
@eliangcs eliangcs force-pushed the update-schema-in-package-lock branch from bc2d3ad to 36dc8aa Compare November 12, 2018 09:03
@eliangcs eliangcs changed the title Update schema in package-lock.json Update schema version in package-lock.json when publishing Nov 12, 2018
@eliangcs eliangcs changed the title Update schema version in package-lock.json when publishing Update schema version in package-lock.json before publishing Nov 12, 2018
@eliangcs eliangcs requested a review from xavdid November 12, 2018 09:10
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! I think at some point it will be worthwhile to switch to yarn. maybe as part of the work that'll happen for splitting cli/core. Might also be able to re-use some of the lerna stuff the frontend uses.

Anyway, that's neither here nor there. This is 👍

I updated the OP to auto close the issue in CLI; hope you don't mind.

@eliangcs
Copy link
Member Author

@xavdid I agree. I think eventually we'll move to monorepo layout and manage all the zapier-platform-* repos (cli, core, schema, and the example apps) in one repo. It'll make development a lot easier.

Also, thanks for defaulting to action, but this PR is not related to zapier/zapier-platform-cli#342, so I'm removing it from the OP.

@eliangcs eliangcs merged commit dee75c4 into master Nov 13, 2018
@eliangcs eliangcs deleted the update-schema-in-package-lock branch November 13, 2018 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants