Be more defensive when creating a buffer

[xavdid]

fixes zapier/zapier-platform-cli#428. We don't addressed nested data in sensitive values, but i've added a failing test to address it though. This doesn't fix that root issue, but it does at least stop throwing errors.

I've also incorporated cooksey's test where we were changing everything to a string. did some related fixes for being better about mutating input.

[codebycaleb]

This looks pretty defensive to me! You might get a merge conflict as I had pushed changes trying to solve a similar problem (https://github.com/zapier/zapier-platform-core/pull/152/files). I think it's probably for the best to discard my line where I casted val to a String (which felt dirty anyways) and just be okay with uncensored base64 numbers. 👍

[xavdid]

Ah, nice! I should have pulled master.

I still can't get a failing test here, so I think i'll hold off merging. I like catching numbers too, since numbers and strings are probably the big offenders. I'll probably end up with a combination of our two solutions, so we censor numbers but don't trip over other things

[kgodtfredsen]

@xavdid Here is the info for the dev who converted their wb app to cli and ran into this issue:

error: https://cdn.zapier.com/storage/files/a69f088d48b696540dee2641a64ff3c1.html

App admin: https://admin.zapier.com/admin/developer_cli/app/20778/change/
App Logs: https://logs.internal.zapier.com/search?q=app_cli_id%3A20778&rangetype=relative&relative=0&fields=fork%2Cmessage%2Cobject_id%2Cobject_action%2Cobject_depth%2Cobject_root_id%2Cselected_api
Source Code of trigger powering dropdown: https://github.com/zapier/zapier-platform-collection/blob/App20778CLIAPI/production/App20778CLIAPI/triggers/list_templates_triggers.js

ticket: https://secure.helpscout.net/conversation/865307594/1296248/

Let us know when this is merged, and we'll let them know.

[xavdid]

ok, so I spent some time debugging this today and didn't quite get there. I incorporated the test from #156 so we could track it down. I'll get back to it Monday!

[xavdid]

ok, got this all set. @codebycaleb can you re-review, it's changed a fair amount. I've updated the description accordingly.

[codebycaleb]

Re-approving - these changes look great! Very readable and easy to follow mentally! 👍