fix(core): add new to url call

[xavdid]

fixes the problem described here

it doesn't look like we've got any testing here, which is why this may have gone undetected so long? I'm also puzzled at why this would have worked at all recently and only broke when we did the godzilla core 8 -> upgrade. In any case, this will fix the issue.

[kgodtfredsen]

https://github.com/zapier/zapier/issues/35833

[eliangcs]

Thanks for fixing!

[eliangcs]

Just found an issue with the attribute name. I'll add a test before we cut a release.

[eliangcs]

Looks like path is not a valid attribute of the URL object.

> const { URL } = require('url')
undefined
> new URL('https://example.com/test/foo').path
undefined
> new URL('https://example.com/test/foo').pathname
'/test/foo'

We should use pathname:

Suggested change

	const path = new urllib.URL(url).path;
	const path = new urllib.URL(url).pathname;

[xavdid]

Weird! So did this never work or was it a node 10 change?

On Mon, Feb 3, 2020 at 6:55 PM Chang-Hung Liang ***@***.***> wrote: ***@***.**** approved this pull request. Just found an issue with the attribute name. I'll add a test before we cut a release. ------------------------------ In packages/core/src/http-middlewares/before/add-digest-auth-header.js <#153 (comment)> : > @@ -15,7 +15,7 @@ const buildDigestHeader = (username, password, url, method, creds) => { ); } - const path = urllib.URL(url).path; + const path = new urllib.URL(url).path; Looks like path is not a valid attribute of the URL object. > const { URL } = require('url') undefined > new URL('https://example.com/test/foo').path undefined > new URL('https://example.com/test/foo').pathname '/test/foo' We should use pathname: ⬇️ Suggested change - const path = new urllib.URL(url).path; + const path = new urllib.URL(url).pathname; — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#153?email_source=notifications&email_token=AAJMYP5T2SPAMXIBQ23RPLDRBCVGTA5CNFSM4KPMQYO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUCO3SQ#pullrequestreview-352644554>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMYP6NTHC4M2HTB5IDR4DRBCVGTANCNFSM4KPMQYOQ> .

-- ~David Brownman Platform Engineer | Zapier <https://zapier.com> c: 303.819.0850 tw: @xavdid

[eliangcs]

@xavdid looking into the git history, that line was originally urllib.parse(url).path (which worked) and got edited to urllib.URL(url).path in PR #46. URL(url).path is not a valid usage, not even on Node 8. It's been there since 8.3.0, so that means digest auth has been broken since 8.3.0. 🤦‍♂

[xavdid]

🙈 I guess digest auth isn't super popular