Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Allow for different changelog version formats #209

Merged
merged 1 commit into from
May 1, 2020

Conversation

codebycaleb
Copy link
Contributor

https://keepachangelog.com/en/1.0.0/ uses a format like so:

but our changelog utils only handled

So this commit just loosens up the restrictions a bit. :)

https://keepachangelog.com/en/1.0.0/ uses a format like so:

but our changelog utils only handled

So this commit just loosens up the restrictions a bit. :)
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Long term I want to move away from markdowns and towards a more structured format. But in the meantime this is cool.

@eliangcs
Copy link
Member

eliangcs commented May 1, 2020

@xavdid a more structural changelog format is good, but I think it'd be nice if we keep supporting the markdown format, so developers can choose their preferred format.

@codebycaleb codebycaleb merged commit 0f7b2c7 into master May 1, 2020
@codebycaleb codebycaleb deleted the update-readme-support branch May 1, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants