Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): improve logging for debugging info #282

Merged
merged 3 commits into from Oct 19, 2020
Merged

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Oct 16, 2020

This is a minor detail that's bugged me for a while - when we converted to oclif, we lost the ability to have custom info when zapier --version was run (which is explicitly asked for when people file issues). This is what we used to do.

This restores availability for some of that info, plus allows us to add more later.

@xavdid xavdid requested a review from eliangcs as a code owner October 16, 2020 22:11
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! But I found zapier -v still prints the same text, unlike zapier --version. Feel free to merge once you fix that.

@xavdid
Copy link
Contributor Author

xavdid commented Oct 19, 2020

Ah, typo! Good eyes as always.

@xavdid xavdid merged commit 1a5c330 into master Oct 19, 2020
@xavdid xavdid deleted the version-improvements branch October 19, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants