Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): return response in middleware #383

Merged
merged 1 commit into from
Jun 4, 2021
Merged

docs(cli): return response in middleware #383

merged 1 commit into from
Jun 4, 2021

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Jun 3, 2021

fixes #382

@xavdid xavdid requested a review from eliangcs as a code owner June 3, 2021 20:24
@@ -11,6 +11,7 @@ const handleErrors = (response, z) => {
} else if (response.status === 200 && response.data.success === false) {
throw new z.errors.Error(response.data.message, response.data.code);
}
return response;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only actual change

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xavdid xavdid merged commit 63e4bad into master Jun 4, 2021
@xavdid xavdid deleted the PDE-2509 branch June 4, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AfterResponse error handling example should return response
2 participants