Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDE-2085 chore: bump node-fetch 2.6.0 -> 2.6.6 (9.x backport) #458

Merged
merged 1 commit into from Dec 1, 2021

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Dec 1, 2021

node-fetch 2.6.0 doesn't encode URLs. For the following program:

const fetch = require('node-fetch');

async function main() {
  const response = await fetch('https://auth-json-server.zapier-staging.com/中文');
  console.log(await response.text());
}

main();

node-fetch 2.6.0 gives you an error:

UnhandledPromiseRejectionWarning: TypeError [ERR_UNESCAPED_CHARACTERS]: Request path contains unescaped characters

Upgrading node-fetch to 2.6.6 fixes the problem.

@eliangcs eliangcs requested a review from xavdid as a code owner December 1, 2021 06:32
@eliangcs eliangcs changed the title PDE-2085 chore(core): bump node-fetch 2.6.0 -> 2.6.6 PDE-2085 chore(core): bump node-fetch 2.6.0 -> 2.6.6 (9.x backport) Dec 1, 2021
@eliangcs eliangcs changed the base branch from master to release-9.x December 1, 2021 06:32
@eliangcs eliangcs changed the title PDE-2085 chore(core): bump node-fetch 2.6.0 -> 2.6.6 (9.x backport) PDE-2085 chore: bump node-fetch 2.6.0 -> 2.6.6 (9.x backport) Dec 1, 2021
@eliangcs eliangcs merged commit f3f95aa into release-9.x Dec 1, 2021
@eliangcs eliangcs deleted the bump-node-fetch branch December 1, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants