Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: zapnap/resque_mailer
base: 717ea55a03
...
head fork: zapnap/resque_mailer
compare: cf29417ac1
Checking mergeability… Don't worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 0 commit comments
  • 2 contributors
Commits on Mar 08, 2012
@andrewpbrett andrewpbrett Emphasize important gotcha. 934263a
Commits on Mar 09, 2012
@zapnap Merge pull request #28 from andrewpbrett/patch-2
Emphasize important gotcha.
cf29417
Showing with 2 additions and 2 deletions.
  1. +2 −2 README.md
View
4 README.md
@@ -27,8 +27,8 @@ method variant:
MyMailer.subject_email(params).deliver!
-Oh, by the way. Don't forget that your async mailer jobs will be processed by
-a separate worker. This means that you should resist the temptation to pass
+Oh, by the way. Don't forget that **your async mailer jobs will be processed by
+a separate worker**. This means that you should resist the temptation to pass
database-backed objects as parameters in your mailer and instead pass record
identifiers. Then, in your delivery method, you can look up the record from
the id and use it as needed.

No commit comments for this range

Something went wrong with that request. Please try again.