Add `staticGzip` middleware #45

Closed
shimaore opened this Issue Sep 15, 2012 · 8 comments

Projects

None yet

4 participants

@shimaore
Member

Pull ee1a3dd

@shimaore
Member

Now it needs tests.

@shimaore shimaore added a commit that referenced this issue Sep 15, 2012
@shimaore shimaore Added `@use 'staticGzip'` #45 @imzshh 0fbcbfd
@imzshh
imzshh commented Sep 19, 2012

Good job:-)

@Radagaisus

What about the Compress middleware? http://expressjs.com/api.html#compress

@imzshh
imzshh commented Nov 14, 2012

staticGzip only compress static files, while the compress middleware compress all response content.

@Radagaisus

The docs says you can pass a filter function for specific file types so we can use that. The reason I'm asking is that using compress means less code to maintain, less packages to depend on and zero tests to write :)

As an off topic: Unless it's a weekend project or a prototype I think nginx / apache should serve the static assets, not node.

@shimaore
Member

How about have our cake and eat it: we could leave the staticGzip option but make gzippo a soft dependency -- similar to what we already do for jsdom, less, etc.

@shimaore
Member
shimaore commented Apr 3, 2013

I seems that gzippo is dead (which makes sense given compress), and that compress (plus staticCache potentially) is the way to go.

I'll add a deprecation warning for staticGzip and I'm planning to remove that feature in a few versions.

@shimaore shimaore added a commit that referenced this issue Apr 3, 2013
@shimaore shimaore deprecate `staticGzip` (#45) 85272cc
@datashaman

This is obsolete. staticGzip is deprecated. Can be closed.

@shimaore shimaore closed this Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment