diff --git a/CHANGELOG.md b/CHANGELOG.md index a2c13686..20d7e1fe 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,8 @@ All notable changes to this add-on will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] - +### Changed +- Remove statements that return the message in HTTP Sender scripts, the message passed as parameter is used/sent always. ## [16] - 2023-03-29 ### Added diff --git a/httpsender/AddBearerTokenHeader.js b/httpsender/AddBearerTokenHeader.js index b7a40095..35a7989e 100644 --- a/httpsender/AddBearerTokenHeader.js +++ b/httpsender/AddBearerTokenHeader.js @@ -20,8 +20,6 @@ function sendingRequest(msg, initiator, helper) { if (initiator !== HttpSender.AUTHENTICATION_INITIATOR && msg.isInScope()) { msg.getRequestHeader().setHeader("Authorization", "Bearer " + ScriptVars.getGlobalVar("access_token")); } - - return msg; } function responseReceived(msg, initiator, helper) {} diff --git a/httpsender/add-extra-headers.js b/httpsender/add-extra-headers.js index ac894ee1..94edd6ee 100644 --- a/httpsender/add-extra-headers.js +++ b/httpsender/add-extra-headers.js @@ -36,7 +36,7 @@ var ignoreHeader = [ function sendingRequest(msg, initiator, helper) { if (initiator === HttpSender.AUTHENTICATION_INITIATOR) { logger("Trying to auth") - return msg; + return; } var hostname = msg.getRequestHeader().getHostName() var varKey = "headers-" + hostname @@ -81,7 +81,6 @@ function sendingRequest(msg, initiator, helper) { msg.getRequestHeader().setHeader(key, extras[key]); } } - return msg; } function responseReceived(msg, initiator, helper) {} diff --git a/httpsender/add-more-headers.js b/httpsender/add-more-headers.js index c625200d..c35ff006 100644 --- a/httpsender/add-more-headers.js +++ b/httpsender/add-more-headers.js @@ -55,8 +55,6 @@ function sendingRequest(msg, initiator, helper) { // logger("Setting " + key + " to " + value); msg.getRequestHeader().setHeader(key, value); } - - return msg; } /* Called after receiving the response from the server. diff --git a/httpsender/maintain-jwt.js b/httpsender/maintain-jwt.js index 2d2cd874..b2612114 100644 --- a/httpsender/maintain-jwt.js +++ b/httpsender/maintain-jwt.js @@ -16,7 +16,7 @@ var COOKIE_TYPE = org.parosproxy.paros.network.HtmlParameter.Type.cookie; function sendingRequest(msg, initiator, helper) { if (initiator === HttpSender.AUTHENTICATION_INITIATOR) { logger("Trying to auth") - return msg; + return; } var token = ScriptVars.getGlobalVar("jwt-token") @@ -26,7 +26,6 @@ function sendingRequest(msg, initiator, helper) { // For all non-authentication requests we want to include the authorization header logger("Added authorization token " + token.slice(0, 20) + " ... ") msg.getRequestHeader().setHeader('Authorization', 'Bearer ' + token); - return msg; } function responseReceived(msg, initiator, helper) {