Reports: XML template fixes #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
reports/xml-fixes
branch
from
b81010f
to
cd064d9
Compare
7 tasks
thc202
approved these changes
Jun 4, 2021
psiinon
force-pushed
the
reports/xml-fixes
branch
from
cd064d9
to
96753d2
Compare
|
Fixed conflicts |
|
@kingthorin @ricekot 2nd review? :) |
|
/ACK Needs spotlessApply |
kingthorin
reviewed
Jun 7, 2021
addOns/reports/src/main/java/org/zaproxy/addon/reports/automation/ReportJob.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
reports/xml-fixes
branch
from
96753d2
to
226e803
Compare
kingthorin
approved these changes
Jun 7, 2021
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where report was not generated via the API.
Made more backwards compatible as per #2952
Fixed issue where you could end up with report.xml.xml (applies to all reports).
Added more detailed tests for the report.
Signed-off-by: Simon Bennetts psiinon@gmail.com