-
Notifications
You must be signed in to change notification settings - Fork 209
Officially require 1.54.0 or greater of Big Bang now #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Racer159
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you also update the following?
https://github.com/defenseunicorns/zarf/blame/main/docs/13-walkthroughs/5-big-bang.md#L113
- Should say "This extension requires Big Bang version
1.54.0or later."
https://github.com/defenseunicorns/zarf/blame/main/examples/git-data/README.md#L31
https://github.com/defenseunicorns/zarf/blob/main/examples/git-data/zarf.yaml#L34
- Should reference 1.54.x instead of 1.53.x
https://github.com/defenseunicorns/zarf/blob/main/src/extensions/bigbang/bigbang.go#L48
https://github.com/defenseunicorns/zarf/blob/main/src/extensions/bigbang/bigbang.go#L147
https://github.com/defenseunicorns/zarf/blob/main/src/extensions/bigbang/bigbang.go#L229
- Should reference 1.54.0 instead
https://github.com/defenseunicorns/zarf/blob/main/src/test/e2e/07_create_git_test.go#L63
https://github.com/defenseunicorns/zarf/blob/main/src/test/e2e/07_create_git_test.go#L68
- Because the
git-dataexample would be changed above these should referencerelease-1.54.x
https://github.com/defenseunicorns/zarf/blob/main/src/test/e2e/07_create_git_test.go#L60
- Again because
git-datachanged, the folderbig-bang-2752174810would change tobig-bang-2705706079for the URL being updated tohttps://github.com/DoD-Platform-One/big-bang.git@refs/heads/release-1.54.x
3bda6c3 to
6d6dcb0
Compare
|
I found an issue with this, when attempting to test against BB |
…po + branch check
08e4866 to
b4cfec0
Compare
Changes pushed. I'm using a library already referenced by another package to parse the semantic version (based on Semver v2). I also added some unit tests. |
Racer159
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small suggestions
Racer159
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
This makes the requirement for the
bigbangcomponent officially 1.54.0 or greater.Related Issue
N/A
Type of change
Checklist before merging