Decouples agent image build process in zarf repository specific makefile - #2025
Merged
Racer159 merged 8 commits intoOct 4, 2023
Conversation
dgershman
requested review from
Noxsios,
Racer159,
cmwylie19 and
jeff-mccoy
as code owners
September 21, 2023 02:15
✅ Deploy Preview for zarf-docs canceled.
|
dgershman
changed the title
Racer159
suggested changes
Sep 23, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Racer159
suggested changes
Sep 29, 2023
Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Noxsios
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change decouples the specific logic about whether or not
AGENT_IMAGE_TAGis set tolocalor not, as the description indicates. When you build the package outside the zarf repository, you get an error message stating it can't find the make target. The logic in the Makefile is such that it would determine whether not this is set as such. By adding this change, you can use thezarf-agentpackage unchanged if wanted, potentially integrating improvements a little easier to track.Related Issue
N/A
Type of change
Checklist before merging