Use (new) buffer protocol in *JSON's decode
#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 2/3, `codecs.decode` performs decoding analogous to `bytes.decode` except that it is not limited to `bytes`. In fact, it can take anything that supports the (new) buffer protocol. Thus we can avoid copying the data and instead only take an `ndarray` view onto it before passing the buffer to `codecs.decode`. Should improve performance a bit by avoiding this copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2/3,
codecs.decodeperforms decoding analogous tobytes.decodeexcept that it is not limited tobytes. In fact, it can take anything that supports the (new) buffer protocol. Thus we can avoid copying the data and instead only take anndarrayview onto it before passing the buffer tocodecs.decode. Should improve performance a bit by avoiding this copy.TODO:
tox -e py37passes locallytox -e py27passes locallytox -e docspasses locally