Skip to content

Conversation

@DimitriPapadopoulos
Copy link
Contributor

It is unnecessary to provide None as the default value when the key is not present in the dictionary as get implicitly returns None.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #395 (306e2b2) into main (7bc303a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         2093      2093           
=========================================
  Hits          2093      2093           
Impacted Files Coverage Δ
numcodecs/ndarray_like.py 100.00% <100.00%> (ø)

@jakirkham
Copy link
Member

cc @ap--

@jakirkham
Copy link
Member

Dimitri, can you please add a news entry and then we can merge?

It is unnecessary to provide None as the default value when the key
is not present in the dictionary as get implicitly returns None.
@DimitriPapadopoulos
Copy link
Contributor Author

Done. This was a minor fix, but it's true it was in actual code.

@jakirkham
Copy link
Member

Thank you! 🙏

@jakirkham jakirkham merged commit 922ab23 into zarr-developers:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants